-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy .eot
, .otf
, .ttf
, .woff
, and woff2
font files when bundling
#12439
Conversation
.ttf
and .woff
files when bundling with esbuild
do we also need to update here? kit/packages/adapter-vercel/index.js Line 137 in 657e52a
|
🦋 Changeset detectedLatest commit: 53ab3fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Yes, that's being updated. It's one of the steps required to get |
.ttf
and .woff
files when bundling with esbuild.ttf
, .woff
, and .woff2
files when bundling with esbuild
@@ -97,7 +97,10 @@ export default function ({ config = 'wrangler.toml', platformProxy = {} } = {}) | |||
alias: Object.fromEntries(compatible_node_modules.map((id) => [id, `node:${id}`])), | |||
format: 'esm', | |||
loader: { | |||
'.wasm': 'copy' | |||
'.wasm': 'copy', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like eot and otf are the other two coming up in my searches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've added .eot
and .otf
too. Just curious, what kind of search are you conducting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd done a good search for "esbuild loader font" or something like that
.ttf
, .woff
, and .woff2
files when bundling with esbuild.eot
, .otf
, .ttf
, .woff
, and woff2
font files when bundling
So apparently this won't do anything until evanw/esbuild#795 is resolved.
|
Should we revert this or just leave it? |
I might have to look at how the manoco editor is referencing their font because it seems esbuild picks it up, which caused the "no loader" error in #11220 we should check to see if the reproducible works after upgrading the adapter |
closes #11219
fixes #11220
Copies
.ttf
and.woff
font files when bundling edge functions since those are the most common font files included with packages. Alternatively, we could use the same list of assets as Vite.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits