Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy .eot, .otf, .ttf, .woff, and woff2 font files when bundling #12439

Merged
merged 7 commits into from
Jul 6, 2024
Merged

fix: copy .eot, .otf, .ttf, .woff, and woff2 font files when bundling #12439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f9f758
copy font files and do not add hash to filename
eltigerchino Jul 5, 2024
d08706b
leave asset names alone
eltigerchino Jul 5, 2024
2a6129e
changeset
eltigerchino Jul 5, 2024
09f1a53
add .woff2
eltigerchino Jul 5, 2024
482c60e
update changeset
eltigerchino Jul 5, 2024
ea14400
add eof and otf
eltigerchino Jul 6, 2024
53ab3fa
oops i mean .eot
eltigerchino Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/silver-bears-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@sveltejs/adapter-cloudflare-workers': patch
'@sveltejs/adapter-cloudflare': patch
'@sveltejs/adapter-netlify': patch
'@sveltejs/adapter-vercel': patch
---

fix: copy `.eot`, `.otf`, `.ttf`, `.woff`, and `woff2` font files when bundling
7 changes: 6 additions & 1 deletion packages/adapter-cloudflare-workers/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ export default function ({ config = 'wrangler.toml', platformProxy = {} } = {})
alias: Object.fromEntries(compatible_node_modules.map((id) => [id, `node:${id}`])),
format: 'esm',
loader: {
'.wasm': 'copy'
'.wasm': 'copy',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like eot and otf are the other two coming up in my searches

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I've added .eot and .otf too. Just curious, what kind of search are you conducting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd done a good search for "esbuild loader font" or something like that

'.woff': 'copy',
'.woff2': 'copy',
'.ttf': 'copy',
'.eot': 'copy',
'.otf': 'copy'
},
logLevel: 'silent'
});
Expand Down
7 changes: 6 additions & 1 deletion packages/adapter-cloudflare/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,12 @@ export default function (options = {}) {
format: 'esm',
bundle: true,
loader: {
'.wasm': 'copy'
'.wasm': 'copy',
'.woff': 'copy',
eltigerchino marked this conversation as resolved.
Show resolved Hide resolved
'.woff2': 'copy',
'.ttf': 'copy',
'.eot': 'copy',
'.otf': 'copy'
},
external,
alias: Object.fromEntries(compatible_node_modules.map((id) => [id, `node:${id}`])),
Expand Down
9 changes: 8 additions & 1 deletion packages/adapter-netlify/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,14 @@ async function generate_edge_functions({ builder }) {
platform: 'browser',
sourcemap: 'linked',
target: 'es2020',

loader: {
'.wasm': 'copy',
'.woff': 'copy',
'.woff2': 'copy',
'.ttf': 'copy',
'.eot': 'copy',
'.otf': 'copy'
},
// Node built-ins are allowed, but must be prefixed with `node:`
// https://docs.netlify.com/edge-functions/api/#runtime-environment
external: builtinModules.map((id) => `node:${id}`),
Expand Down
7 changes: 6 additions & 1 deletion packages/adapter-vercel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,12 @@ const plugin = function (defaults = {}) {
sourcemap: 'linked',
banner: { js: 'globalThis.global = globalThis;' },
loader: {
'.wasm': 'copy'
'.wasm': 'copy',
'.woff': 'copy',
'.woff2': 'copy',
'.ttf': 'copy',
'.eot': 'copy',
'.otf': 'copy'
}
});

Expand Down
Loading