-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when a Svelte config is not found #3219
Conversation
🦋 Changeset detectedLatest commit: b70a118 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: b70a118 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d7ad34dda44000083efb39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a changeset, other than that this looks good 👍
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This still isn't a great error message though — it should be a much more explicit 'Missing svelte.config.js', or perhaps
You need to create a svelte.config.js file — see https://kit.svelte.dev/docs#configuration
In fact, there's already some logic for that, it's just a) in a weird place that means it never actually runs, and b) overly complicated. We should just check to see if svelte.config.js
or svelte.config.cjs
exists, and if not throw a helpful error inside load_config
Thanks. Realised we can actually simplify this stuff quite a bit, because the checks for |
svelte-kit
error message can be a bit confusing when bothsvelte.config.js
andsvelte.config.cjs
are absent.We need
svelte.config.js
, notsvelte.config.cjs
:After this PR:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0