Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when a Svelte config is not found #3219

Merged
merged 14 commits into from
Jan 7, 2022
Merged

Improve error message when a Svelte config is not found #3219

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ab44a00
Improve an error message for MODULE_NOT_FOUND
Jan 6, 2022
c78894f
Add a changeset
Jan 6, 2022
01a59ad
Update a changeset
ykomatsu Jan 6, 2022
b0ced2d
Move some error messages
Jan 7, 2022
d0262d5
Move some error messages again
Jan 7, 2022
dba6464
Update
Jan 7, 2022
e611912
remove support for svelte.config.cjs
Rich-Harris Jan 7, 2022
6e080b1
merge master -> load_config
Rich-Harris Jan 7, 2022
07782c9
tweak changeset
Rich-Harris Jan 7, 2022
f248a48
simplify config error handling
Rich-Harris Jan 7, 2022
661a55c
simplify further
Rich-Harris Jan 7, 2022
947f08e
lint
Rich-Harris Jan 7, 2022
b09e8a1
merge master -> load-config
Rich-Harris Jan 7, 2022
b70a118
update test
Rich-Harris Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-points-exercise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Improve error message when a Svelte config is not found
11 changes: 7 additions & 4 deletions packages/kit/src/core/config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,13 @@ export function load_template(cwd, config) {
}

export async function load_config({ cwd = process.cwd() } = {}) {
const config_file_esm = path.join(cwd, 'svelte.config.js');
const config_file = fs.existsSync(config_file_esm)
? config_file_esm
: path.join(cwd, 'svelte.config.cjs');
let config_file = path.join(cwd, 'svelte.config.js');
const config_file_cjs = path.join(cwd, 'svelte.config.cjs');

if (!fs.existsSync(config_file) && fs.existsSync(config_file_cjs)) {
config_file = config_file_cjs;
}

const config = await import(url.pathToFileURL(config_file).href);

const validated = validate_config(config.default);
Expand Down