Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port banner from svelte.dev #4155

Merged
merged 1 commit into from
Feb 28, 2022
Merged

port banner from svelte.dev #4155

merged 1 commit into from
Feb 28, 2022

Conversation

benmccann
Copy link
Member

copying over from sveltejs/sites#308

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2022

⚠️ No Changeset found

Latest commit: 8a6fd18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 353d94e into master Feb 28, 2022
@Rich-Harris Rich-Harris deleted the antiwar branch February 28, 2022 16:19
pngwn
pngwn approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! we don't need all of the CSS here but it is easy to strip it out when the time comes.

@sveltejs sveltejs locked as too heated and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pngwn pngwn pngwn approved these changes

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @Rich-Harris @pngwn