-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ukraine support banner #308
Conversation
This pull request is being automatically deployed with Vercel (learn more). svelte-dev – ./sites/svelte.dev🔍 Inspect: https://vercel.com/svelte/svelte-dev/6GQ6Au87r72eM2kVnHSkmfGoZ5dK hn – ./sites/hn.svelte.dev🔍 Inspect: https://vercel.com/svelte/hn/Hdto4eSynRb2LGbrWKtQbQjjGXyC |
ACK |
This looks good on mobile everywhere except the docs. On FF the banner is placed weirdly and Chrome is completely confused. |
@dummdidumm Do you have some screenshots? It looks okay for me on chrome. Will check FF. I don't want to make it closable. |
@vedam created a nice svelte + Ukraine flag logo, should we add it? I like it. |
Pushed the version with the logo @vedam provided so you can see for yourself. Can remove it if needed. |
The banner stays at the bottom correctly now on mobile, but the banner hides the mobile menu that is in the bottom left. |
@dummdidumm Fixed in latest commit. |
This PR adds a banner at the bottom of the site showing our support for Ukraine in this time of crisis. It also provides a link directing people to support the efforts. I use the colours of the flag of Ukraine, as best I could emulate them.
I have added some padding and tweaked some heights to ensure that content is not hidden by the banner (particularly on mobile). Screenshots below