Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ukraine support banner #308

Merged
merged 8 commits into from
Feb 28, 2022
Merged

feat: add ukraine support banner #308

merged 8 commits into from
Feb 28, 2022

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Feb 28, 2022

This PR adds a banner at the bottom of the site showing our support for Ukraine in this time of crisis. It also provides a link directing people to support the efforts. I use the colours of the flag of Ukraine, as best I could emulate them.

I have added some padding and tweaked some heights to ensure that content is not hidden by the banner (particularly on mobile). Screenshots below
Screenshot 2022-02-28 at 11 08 53
Screenshot 2022-02-28 at 11 10 18
Screenshot 2022-02-28 at 11 10 26

@vercel
Copy link

vercel bot commented Feb 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

svelte-dev – ./sites/svelte.dev

🔍 Inspect: https://vercel.com/svelte/svelte-dev/6GQ6Au87r72eM2kVnHSkmfGoZ5dK
✅ Preview: https://svelte-dev-git-ukr-banner-svelte.vercel.app

hn – ./sites/hn.svelte.dev

🔍 Inspect: https://vercel.com/svelte/hn/Hdto4eSynRb2LGbrWKtQbQjjGXyC
✅ Preview: https://hn-git-ukr-banner-svelte.vercel.app

@kevmodrome
Copy link
Contributor

ACK

@dummdidumm
Copy link
Member

dummdidumm commented Feb 28, 2022

This looks good on mobile everywhere except the docs. On FF the banner is placed weirdly and Chrome is completely confused.
Side note: do we want to make this closable? Especially if it's causing layout issues like mentioned above it might be good for some, but I also understand the arguments for making it unclosable.

@pngwn
Copy link
Member Author

pngwn commented Feb 28, 2022

@dummdidumm Do you have some screenshots? It looks okay for me on chrome. Will check FF.

I don't want to make it closable.

@pngwn
Copy link
Member Author

pngwn commented Feb 28, 2022

@vedam created a nice svelte + Ukraine flag logo, should we add it? I like it.

Screenshot 2022-02-28 at 11 50 18

@pngwn
Copy link
Member Author

pngwn commented Feb 28, 2022

Pushed the version with the logo @vedam provided so you can see for yourself. Can remove it if needed.

@dummdidumm
Copy link
Member

The banner stays at the bottom correctly now on mobile, but the banner hides the mobile menu that is in the bottom left.

@pngwn
Copy link
Member Author

pngwn commented Feb 28, 2022

@dummdidumm Fixed in latest commit.

@pngwn pngwn merged commit ce0750b into master Feb 28, 2022
@Rich-Harris Rich-Harris deleted the ukr-banner branch February 28, 2022 14:14
@sveltejs sveltejs locked as too heated and limited conversation to collaborators Feb 28, 2022
@sveltejs sveltejs deleted a comment from denisxab Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants