Prerender during build #4192
Merged
Prerender during build #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9545b8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Mar 3, 2022
| @@ -224,6 +224,7 @@ See [Prerendering](/docs/page-options#prerender). An object containing zero or m | |||
|
|
|||
| - `concurrency` — how many pages can be prerendered simultaneously. JS is single-threaded, but in cases where prerendering performance is network-bound (for example loading content from a remote CMS) this can speed things up by processing other tasks while waiting on the network response | |||
| - `crawl` — determines whether SvelteKit should find pages to prerender by following links from the seed page(s) | |||
| - `default` — set to `true` to prerender every page without `export const prerender = false` | |||
There was a problem hiding this comment.
I wonder if we should combine default and enabled into a single option. E.g. with values like true | false | 'never' or 'default-true' | 'default-false' | 'never'
There was a problem hiding this comment.
I think I prefer the booleans, personally
This was referenced Mar 5, 2022
This was referenced Mar 5, 2022
jamesscottbrown
added a commit
to networkcube/vistorian-monorepo
that referenced
this pull request
Mar 9, 2022
This restores the creation of HTML files after this was broken by a recent change to sveltekit: sveltejs/kit#4192
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4112
Closes #3792
Closes #2271
Closes #923
config.kit.prerender.defaultoption (defaults tofalse)build, and passbuilder.prerenderedobject to adaptersbuilder.writePrerendered(dest, { fallback })methoddefaultoption inbuilder.prerendered, so e.g.adapter-staticcan warn ifdefaultwasfalsewhen there's nofallbacksvelte-kit previewprerenderedavailable to service workersPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0