-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose caches
to Cloudflare adapter through Platform
#5081
Expose caches
to Cloudflare adapter through Platform
#5081
Conversation
🦋 Changeset detectedLatest commit: 5ca08b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I'm not the most familiar with Cloudflare, so will leave this for others to review as well
@@ -66,7 +66,8 @@ declare namespace App { | |||
+ }; | |||
+ context: { | |||
+ waitUntil(promise: Promise<any>): void; | |||
+ } | |||
+ }; | |||
+ caches: CacheStorage & { default: Cache } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should show these in alphabetical order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put caches
at the bottom because it is the least likely to be used.
thank you! |
This PR exposes Cloudflare's Worker Cache API as
caches
in theplatform
object. This allows hooks to do elaborate caching, for example, I use the Cache API to cache certain pages based on request cookies.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0