Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose caches to Cloudflare adapter through Platform #5081

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Expose caches to Cloudflare adapter through Platform #5081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bdc37d
Expose `caches` to Cloudflare adapter
venashial May 26, 2022
5ca08b5
Add changeset
venashial May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sixty-bees-explain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-cloudflare': minor
---

Expose Cloudflare Worker Cache API through `caches` in Platform
5 changes: 3 additions & 2 deletions packages/adapter-cloudflare/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ When configuring your project settings, you must use the following settings:

## Environment variables

The [`env`](https://developers.cloudflare.com/workers/runtime-apis/fetch-event#parameters) object, containing KV namespaces etc, is passed to SvelteKit via the `platform` property along with `context`, meaning you can access it in hooks and endpoints:
The [`env`](https://developers.cloudflare.com/workers/runtime-apis/fetch-event#parameters) object, containing KV namespaces etc, is passed to SvelteKit via the `platform` property along with `context` and `caches`, meaning you can access it in hooks and endpoints:

```diff
// src/app.d.ts
Expand All @@ -66,7 +66,8 @@ declare namespace App {
+ };
+ context: {
+ waitUntil(promise: Promise<any>): void;
+ }
+ };
+ caches: CacheStorage & { default: Cache }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should show these in alphabetical order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put caches at the bottom because it is the least likely to be used.

+ }

interface Session {}
Expand Down
2 changes: 1 addition & 1 deletion packages/adapter-cloudflare/src/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const worker = {
} else {
// dynamically-generated pages
res = await server.respond(req, {
platform: { env, context },
platform: { env, context, caches },
getClientAddress() {
return req.headers.get('cf-connecting-ip');
}
Expand Down