Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you introduce an error into a component that causes rendering to fail...
...fixing the component won't cause the page to recover, because Svelte itself is now in a broken state. (We plan to make Svelte more resilient to this sort of thing, but it's a ways off.) Adding
hot.optimistic: false
to thevite-plugin-svelte
options causes the page to reload on HMR updates after a rendering error is encountered.That solves half the problem. If the page reloads and it's still broken, the server will render an error page. Since the error page generally won't use the component where the error was, subsequent HMR updates will be ignored, so fixing the component won't cause the error page to go away.
I think a reasonable way to fix that is to always reload the page when an HMR update occurs, if you're on an error page.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0