Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robustify error handling #5108

Merged
merged 4 commits into from
May 30, 2022
Merged

robustify error handling #5108

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bad2a1f
robustify error handling
Rich-Harris May 29, 2022
f725f26
bump vite-plugin-svelte
Rich-Harris May 30, 2022
c0915ba
remove hot.optimistic override
Rich-Harris May 30, 2022
9d66370
try to fix typechecking errors
Rich-Harris May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-cars-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Reload page to recover from HMR errors
3 changes: 3 additions & 0 deletions packages/kit/src/core/dev/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,9 @@ export const svelte = function (svelte_config) {
...svelte_config.compilerOptions,
hydratable: !!svelte_config.kit.browser.hydrate
},
hot: {
optimistic: false
Rich-Harris marked this conversation as resolved.
Show resolved Hide resolved
},
Rich-Harris marked this conversation as resolved.
Show resolved Hide resolved
configFile: false
});
};
Expand Down
6 changes: 6 additions & 0 deletions packages/kit/src/runtime/client/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,6 +986,12 @@ export function create_client({ target, session, base, trailing_slash }) {
return new Promise(() => {});
}

if (import.meta.hot) {
import.meta.hot.on('vite:beforeUpdate', () => {
if (current.error) location.reload();
});
}

return {
after_navigate: (fn) => {
onMount(() => {
Expand Down