-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
await blocks fail when using CRLF line endings #1132
Labels
Comments
Interesting. Invalid js isn't being generated for other types of tags/blocks/etc that you've noticed? Once we fix this, it would be good to extend the tests so that they're also run with |
Correct, I've used each and if blocks with no issue thus far |
Conduitry
added a commit
that referenced
this issue
Jan 25, 2018
Rich-Harris
added a commit
that referenced
this issue
Jan 26, 2018
Rich-Harris
added a commit
that referenced
this issue
Jan 26, 2018
fix handling of CRs in debugging comments (#1132)
Thanks — released 1.54 with @Conduitry's fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using the await example from the repl on windows (line endings CRLF) generates invalid javascript that webpack chokes on as you can see below. Changing the file to LF fixes the issue.
webpack stack trace
The text was updated successfully, but these errors were encountered: