fix handling of CRs in debugging comments (#1132) #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 125 125
Lines 4522 4522
Branches 1459 1459
=======================================
Hits 4137 4137
Misses 163 163
Partials 222 222
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1132.
Build failures are unrelated, and are from #1127.
Carriage returns
\rwere being kept in the debugging comments, which produced invalid javascript. Changing the regex to replace\nor\rwith spaces worked, but it seemed slightly safer/tidier to just replace all whitespace\swith spaces.This does not extend the runtime tests to also try compiling each component with LF replaced with CRLF. For some mysterious reason, the method I was trying (doing the replace in the require hook according to the value of a flag) was just not working - I want to revisit that, either later in this PR, or in another issue/PR.