Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle_lazy_image not called for nested images in static block #14312

Closed
brunnerh opened this issue Nov 15, 2024 · 2 comments · Fixed by #14317
Closed

handle_lazy_image not called for nested images in static block #14312

brunnerh opened this issue Nov 15, 2024 · 2 comments · Fixed by #14317
Assignees
Labels

Comments

@brunnerh
Copy link
Member

Describe the bug

Not sure if the call should be there, but for static images nested in a e.g. a static <div>, it's gone.

(Tested this in relation to changes from #14269, but if this behavior is wrong, it has been wrong before as well.)

Reproduction

<!-- No call -->
<div><img src="..." loading="lazy" /></div>

<!-- This would have the call: -->
<!-- <img src="..." loading="lazy" /> -->

Playground

Logs

No response

System Info

REPL

Severity

annoyance

@dummdidumm dummdidumm added the bug label Nov 15, 2024
@dummdidumm
Copy link
Member

We're likely missing logic to mark the subtree as dynamic in this case - though it's tricky, because it probably also undoes a lot of the optimization around shrinking code size / inlining expressions.

@paoloricciuti
Copy link
Member

We're likely missing logic to mark the subtree as dynamic in this case - though it's tricky, because it probably also undoes a lot of the optimization around shrinking code size / inlining expressions.

i think i've added logic about this but it was probably removed during the rework. Let me see how easy is to fix this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants