Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid marking subtree as dynamic for inlined attributes #14269

Merged
merged 42 commits into from
Nov 14, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Nov 11, 2024

Closes #14241 (this time for real...i don't think we can get less than this but happy to be proved wrong by @benmccann 😄 )

I've restructured the code a bit to have a shared utils.

Also fixes #14292

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 61b60ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14269-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14269

@paoloricciuti
Copy link
Member Author

Also for some reason when i tried to import extract_all_identifiers_from_expression it was not able to run the playground anymore 🤷🏼

paoloricciuti and others added 2 commits November 12, 2024 21:11
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@paoloricciuti
Copy link
Member Author

@Rich-Harris obviously thanks for taking care of solving this...I suspected something was very wrong (I can't be at the desk now but please let me know if I need to do something) 🤟🏻

…ier.js

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versions >5.1.14 causing TypeError: Illegal invocation error Compiler output bloat
3 participants