-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid marking subtree as dynamic for inlined attributes #14269
Conversation
🦋 Changeset detectedLatest commit: 61b60ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14269-svelte.vercel.app/ this is an automated message |
|
packages/svelte/src/compiler/phases/2-analyze/visitors/ExpressionTag.js
Outdated
Show resolved
Hide resolved
Also for some reason when i tried to import |
packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/fragment.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/utils.js
Outdated
Show resolved
Hide resolved
packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/fragment.js
Outdated
Show resolved
Hide resolved
@Rich-Harris obviously thanks for taking care of solving this...I suspected something was very wrong (I can't be at the desk now but please let me know if I need to do something) 🤟🏻 |
packages/svelte/src/compiler/phases/2-analyze/visitors/Identifier.js
Outdated
Show resolved
Hide resolved
…ier.js Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Closes #14241 (this time for real...i don't think we can get less than this but happy to be proved wrong by @benmccann 😄 )
I've restructured the code a bit to have a shared utils.
Also fixes #14292
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint