-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This warning should be removed - A11y: Media elements must have a <track kind="captions"> #5967
Comments
I agree that it makes sense to remove this check for
However, the same is not true for the corresponding rule for As a side note, I don't read the warning as suggesting you add an empty |
Also note that the Svelte tutorial currently has a compiler warning for missing audio captions. Either the rule should not check audio elements or the tutorial should be updated to resolve the warning. This is also a case where it wouldn't make sense to have captions even if audio captions were supported since it's music only, no speech. |
The one for Svelte tutorial having invalid fake
|
Only to someone familiar enough with the FWIW, I like the solution proposed in this issue better than the proposed solution in mine. |
I agree...I followed this direction and put a |
I opened a PR to remove the warning for audio elements since it's causing the most issues and browsers don't support it. I made sure to note in the PR that it doesn't completely resolve this issue, since there's still some discussion around removing the warning for video elements as well. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
just to chime in here, we are building a custom video conferencing app using AWS chime and svelte. We get this warning when we are using the |
More often than not this warning isn't helpful at all. There are numerous reasons why captions wouldn't make sense + some libraries like hls.js set captions dynamically via Even in one of the official tutorials there's a dummy |
commit c7dcfac883a34655421932258d3d5a3b0ee96362 Author: Theodore Brown <theodorejb@outlook.com> Date: Mon Mar 13 12:21:51 2023 -0500 fix: select option with selected attribute when initial state is undefined (#8371) Resolves a second unintended regression introduced in #6170. Follow-up to #8331, this time addressing the root issue so the correct select option won't be deselected in the first place when the initial bound value is undefined. Fixes #8361 commit 5c14bc5f0133cf6ae7d96d30f5cc6824e9f006aa Author: Lyu, Wei-Da <36730922+jasonlyu123@users.noreply.github.com> Date: Fri Mar 10 16:47:30 2023 +0800 fix: support es2022 class features (#8355) Follow up to #8349. We also have to bump the parsing ECMAScript version here. Fixes #6900, fixes #6592. commit e2fe8ab46966a7c3a6702e7e5f71ac316c553288 Author: Conduitry <git@chor.date> Date: Thu Mar 9 19:31:19 2023 -0500 -> v3.56.0 commit 80e6e2820408bdd1752cc1b866d106ad6c1d8824 Author: Conduitry <git@chor.date> Date: Thu Mar 9 05:04:38 2023 -0500 chore: mark Promise.resolve() as pure to appease Agadoo (#8366) commit f9efb4d9920ff76b4b22bec8443ee2049a05cf26 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Wed Mar 8 09:56:24 2023 -0800 chore: upgrade aria-query (#8353) commit 757a81ac6db186b707fceb2a4be37b852a99102f Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Wed Mar 8 08:50:11 2023 -0800 chore: upgrade dependencies (#8352) commit 11af8509242956d5414fd8dc3205a40855437ab5 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Mon Mar 6 09:41:38 2023 +0100 fix: correct meta attributes fixes https://github.com/sveltejs/language-tools/issues/1917 commit c6d6a73b9d5b34ab84fa0febcf70c06a2bd7b08e Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri Mar 3 23:18:55 2023 -0800 chore: upgrade rollup plugins (#8350) commit b336b162041d4f33252e12f15c98d89ecf2dcf23 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri Mar 3 23:18:25 2023 -0800 chore: upgrade to code-red 1.0 (#8349) commit 5b2fa1f24750b77b83dcac831978efc93a6451fc Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Thu Mar 2 11:10:12 2023 -0800 chore: upgrade magic-string (#8339) - overwrite -> update - update comments commit 0966d1d282b04cec6f3b0d34a4ba73dae2d08d56 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Fri Mar 3 02:57:38 2023 +0800 feat: improve `bind:group` behavior (#7892) track all `#each` variables that could result in a change to the inputs and also update the `$$binding_groups` variable which holds the references to the inputs of each group accordingly. Fixes #7633 Fixes #6112 Fixes #7884 commit 6476e9b34fa1bf8510082191f5c067c1fa25b3f1 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu Mar 2 16:57:36 2023 +0100 fix: add visibility event to types commit e2b9df1888775bd5d7349fb81c1e7038942c038c Author: Brandon McConnell <brandon@dreamthinkbuild.com> Date: Thu Mar 2 06:38:43 2023 -0500 docs: update 06-accessibility-warnings.md (#8342) Convert recommended events to use Svelte syntax, and include deprecation warning re https://developer.mozilla.org/en-US/docs/Web/API/Element/keypress_event commit d525901556bfc5575150ccd6b198a413dfff1bb3 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Mar 2 16:24:33 2023 +0800 fix validation for global compound selector (#8344) commit fbaf3cfc1249645e7f0cc49fa3caab0a4ed6433e Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Mar 2 00:28:37 2023 +0800 fix: call `<svelte:component>` update to `this` only when it's dirty (#4192) Closes #4129 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> commit 311193f1d7dd7f04904567660b997f38c7b32e5b Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Wed Mar 1 15:49:18 2023 +0100 chore: update changelog commit c0bc86e214ca0130b78bd714f5495e945b1a6c53 Author: Dane David <dndavid102@gmail.com> Date: Wed Mar 1 14:45:50 2023 +0100 feat: support exclusively special characters in component filenames (#7664) Fixes #7143 --------- Co-authored-by: Tan Li Hau <tanhauhau@users.noreply.github.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit dd371f58fe4c472ebce9c33c942f572fc58415c8 Author: Brad Dougherty <me@brad.is> Date: Wed Mar 1 05:54:00 2023 -0500 feat: add readyState binding for media elements (#6843) Closes #6666 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit c611f318d2fcc951f05df3cb17db95d60e34609b Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Wed Mar 1 18:51:40 2023 +0800 feat: add stopImmediatePropagation event modifier (#8341) Closes #5085 --------- Co-authored-by: Marcin Wicha <23581770+marcin-wicha@users.noreply.github.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit acbf8135a8a905bc84078cd2145b83d52b325410 Author: Roy Choo <roychoo@hotmail.com> Date: Wed Mar 1 18:28:59 2023 +0800 fix: add global compound selector validation (#6322) fixes #6272 prevents invalid CSS output --------- Co-authored-by: Roy Choo <roy.choo@bytedance.com> Co-authored-by: tanhauhau <lhtan93@gmail.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit ed575cc9270b92564d8e0bec86aa88d0412af9ac Author: Nguyen Tran <88808276+ngtr6788@users.noreply.github.com> Date: Wed Mar 1 05:06:15 2023 -0500 fix: make svelte-ignore work above components (#8338) Fixes #8082, where svelte-ignore somehow does not pick up the reactive-component warning. The issue on this problem is that the map_children function suppresses warnings and errors while traversing AST nodes as src/compiler/compile/nodes classes. However, the reactive-component warning is called in src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts, and its warnings are not suppressed in map_children. Thus, we need to extract ignores and suppress here separately. commit dc36d0c9afc352587a0e512aac7704c734390e92 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Feb 28 22:42:59 2023 +0100 fix: typings for naturalWidth/Height bindings follow-up to #7857 commit b5b0d1f2d4eeb2c5b0fc22ed3f38a22eff06e1bb Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Feb 28 22:39:23 2023 +0100 chore: update changelog commit 6ec5a0ed2450db94d1873b09841f2092f15d79a2 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Feb 28 18:40:23 2023 +0100 chore: update changelog commit f34abc568920265b848228c32d67eae10f1b589f Author: xxkl1 <84455605+xxkl1@users.noreply.github.com> Date: Wed Mar 1 01:21:39 2023 +0800 fix: decode html entities correctly (#8047) fixes #8026 1. replace the big entities list with entities that have a ; at the end where valid (there are some exceptions) 2. construct two regexes from that entities list: one for HTML where it's strictly matched, one for attributes where it tries to match browser behavior by also allowing = / digit / character afterwards 3. decode character references with one of these regexes depending on this is an attribute value or not --------- Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit aa15a64cbefff009073fc298b5df679bf385f9c8 Author: lidlanca <8693091+lidlanca@users.noreply.github.com> Date: Tue Feb 28 12:16:55 2023 -0500 fix: account for `<template>` tag in `{@html}` (#7364) Ensure innerHTML for template is done on template element fixes #7315 fixes #7319 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit dc7fd76e53986238228ddad20fbc536de17568e3 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Wed Mar 1 00:03:06 2023 +0800 Update CHANGELOG.md commit 60db05da86bf65e9b8e710b72b2d81c9efac2441 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Feb 28 17:01:40 2023 +0100 fix: hide some a11y warnings for `<svelte:element>` tags (#8335) Some a11y warnings only work on specific tags, which results in potential false positives for `<svelte:element>` tags - silence those closes #7939 commit f1c9168aefcd46501f99359b880ded1f81b007ed Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Tue Feb 28 23:59:11 2023 +0800 Update CHANGELOG.md commit f6dc86f02c782174071fa77493a3058c681b8f8b Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Tue Feb 28 23:57:45 2023 +0800 feat: optimise svelte-element output code for static tag and static attribute (#8161) * feat: optimise svelte-element output code for static tag and static attribute * Update src/compiler/compile/render_dom/wrappers/Element/index.ts Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * Update src/runtime/internal/dom.ts Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * Update src/compiler/compile/render_dom/wrappers/Element/index.ts Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * fix logic * fix pipeline errors --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit d4363510fc3752f5e49b7ac1757713488990b72b Author: Invader Zim <85027668+zim0369@users.noreply.github.com> Date: Tue Feb 28 14:14:39 2023 +0530 docs: add console output instruction to tutorial (#8336) commit c7bbe55b9f6edda0fb8e1974c47d6260489dbdad Author: Theodor Steiner <40017636+Theo-Steiner@users.noreply.github.com> Date: Tue Feb 28 01:58:23 2023 +0900 feat: introduce axis parameter to allow for horizontal slide transition (#6183) --------- Co-authored-by: Tan Li Hau <tanhauhau@users.noreply.github.com> commit b5ec863a0ea4ed7334b46850f68d9942cdaa333a Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Mon Feb 27 17:13:50 2023 +0100 chore: update changelog commit 32a94fcfc5b119d8cc142d6489e308381f26ccc2 Author: Cory Virok <coryvirok@users.noreply.github.com> Date: Mon Feb 27 07:32:45 2023 -0800 chore: implemented a small runtime optimization for SSR (#7539) Prior to this change, the compiler would generate a template literal that had many purely static string variables nested within it. This change collapses these static strings into the surrounding template literal which should result in (minor) size and performance improvements for the SSR generated code. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> commit fc5f6298129c04214110abb9e5d9046d32691c07 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Feb 27 22:04:20 2023 +0800 Update CHANGELOG.md commit 4e8efd3c1e3002a894910cfad6a3389257cb7434 Author: David Hunt <davidhuntatwork@gmail.com> Date: Mon Feb 27 06:02:34 2023 -0800 fix: fixes sveltejs/svelte#8214 `bind:group` to `undefined` (#8215) * fixes sveltejs/svelte#8214 bind:group to undefined * fix code and add test --------- Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 26104eaaba38ad1e14221870c2c97d00f51ef868 Author: Vaibhav Rai <raivaibhav08@gmail.com> Date: Mon Feb 27 18:15:14 2023 +0530 fix: no error assigning to a `const` property (#7966) Fixes #7964 currently for a case where the parent type is ArrayPattern code needs to check if the elements are of direct type MemberExpression or Identifier, in the case of MemberExpression there will be an Identifier check for the Object of the MemberExpression. --------- Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 9edd2df0d36c302feec36ba2851268def850389c Author: 4eb0da <4eb0da@users.noreply.github.com> Date: Mon Feb 27 15:36:57 2023 +0300 fix: check each_blocks is empty on mount (#7505) fixes #8282 commit 474a13ad90460ea5a9073fa7198c09229f029129 Author: Nico Beierle <nico.beierle@gmail.com> Date: Mon Feb 27 13:25:24 2023 +0100 fix: prevent undefined value when remount keyed input element with spread props (#7699) Fixes: #7578 When remounting a keyed input element (e.g. because the element order has changed) with spread properties, the input value gets undefined. This has happened because data_value is updated before remounting and it won't contain a value for input-value (because the value hasn't changed). When calling mount() an undefined value was assigned because of a missing check. commit 8cf037c90461c5ce2fb0f0c552868d045d5c9b3f Author: Theodore Brown <theodorejb@outlook.com> Date: Mon Feb 27 06:11:06 2023 -0600 fix: select first enabled option by default when initial value is undefined (#8331) Fixes an unintended regression introduced in #6170. Fixes #7041 commit 69c199feac727e8f647dff220b17df5422401711 Author: adiGuba <frederic.martini@gmail.com> Date: Mon Feb 27 13:10:22 2023 +0100 fix: race condition in `svelte:element` with transition #7948 (#7949) fixes #7948 - The assignment of the variable "previous_tag" was incorrectly positioned and could cause race condition when used with transitions. - We need another variable to detect when we are in a transition to remove a node --------- Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 60a205edb8ac8ee6022eae968b5f53893445b137 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Feb 27 21:00:35 2023 +0900 fix: don't set selected option(s) if value is unbound or not passed (#8329) fix: #5644 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit b56dfe51a8a9e753a456ba152e9f71c8d4eb5bed Author: Nguyen Tran <88808276+ngtr6788@users.noreply.github.com> Date: Mon Feb 27 06:28:59 2023 -0500 feat: add a11y `role-supports-aria-props` (#8195) #820 --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> commit 5f99ae76ce4ad1b1be2a08a19a93a44178720523 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Feb 27 19:40:24 2023 +0900 chore: Reduce number of lines of expected files (#8325) - removes character and pos from the expected output to reduce noise - adds a test that pos/character are correct commit 636290af954a2b37a263b35c6deb69f149b59905 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Mon Feb 27 11:33:45 2023 +0100 fix: remove indeterminate from boolean attributes (#8334) It's only existing as a boolean property cleanup of #7944 commit 3423bf6b307d11a44f6a9a71f988e32e198a360e Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Sun Feb 26 23:40:36 2023 +0900 add docs (#8326) commit 79c64df41bfc907d5d65aea6e0add1f3b9441c9d Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Sun Feb 26 22:37:15 2023 +0800 Update CHANGELOG.md commit 1f3d2f7646190213e83936146e16ca2eb2f650b0 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Sun Feb 26 23:35:00 2023 +0900 fix: better handling of inert attribute (add tests) (#7944) * add inert to attribute_lookup * typed for preventing a repeat of the tragedy * add tests * revert unnecessary change * add more test --------- Co-authored-by: fcrozatier <frederic.crozatier@protonmail.com> commit ca531519a8927a8d7cc227ab56efafcf6bc9a3c8 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri Feb 24 15:50:22 2023 -0800 chore: switch to @jridgewell/sourcemap-codec (#8321) commit d16dd5d7caa9e9d992bcd765d980ebc23d796528 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Fri Feb 24 21:20:44 2023 +0800 feat: add naturalWidth and naturalHeight bindings (#7857) Closes #7771 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> commit ba8f979f03da248aa081c7208e0bfcaf63b73a06 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu Feb 23 18:49:49 2023 +0100 chore: update changelog commit 487fedce6c3c4ef817682c904a17a80989db1cd8 Author: Mike Randazzo <slashrandazzo@gmail.com> Date: Thu Feb 23 04:46:08 2023 -0800 docs: describe that `bind:value` creates a two-way binding (#8311) --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit 835362af88fea76b376d31a994690fb58f12591b Author: Hong-Kuan Wu <whk0313@gmail.com> Date: Thu Feb 23 19:36:27 2023 +0800 fix: check url and search input field values before updating (#7111) Fixes #7027 commit 9f89a92d31156502c0b04ec6dd53952face37ca7 Author: Alvin Ramskogler <62756994+blaumeise20@users.noreply.github.com> Date: Thu Feb 23 11:17:34 2023 +0000 feat: add `readonly` method to convert writable store to readonly (#6518) commit 0bdb59c2e2b7664db0ca4bcd9bf7f3934273ae14 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu Feb 23 12:03:29 2023 +0100 fix: compute rect directly before crossfading (#8314) closes #4344 fixes #4111 commit e5b0b6235dbc3483a1d1feb3fe8abf12f13bebd8 Author: Jos de Jong <wjosdejong@gmail.com> Date: Thu Feb 23 12:03:12 2023 +0100 fix: ensure `bind:offsetHeight` updates (#8096) fixes #4233 by calling the callback after the iframe loads, which may be asynchronous --------- Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 709264a94cbd29093349ac86e3edd0acc6af46b0 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Wed Feb 22 20:08:46 2023 +0100 chore: update changelog commit 53de73d08cdf2fb62dca7949767f120f3fac9629 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Feb 23 03:02:42 2023 +0800 feat: simpler output for reactive vars if dependencies are all static (#7942) commit c9a269c149cf968e5e21946fff8a3d14fa972058 Author: Vaibhav <vibovenkat@gmail.com> Date: Wed Feb 22 10:19:33 2023 -0600 fix: silence no content a11y warning if the tag has an aria-label (#8299) fixes #8296 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit 35599972233dceee9d2074ad85ebac9f5a43730a Author: ngtr6788 <88808276+ngtr6788@users.noreply.github.com> Date: Wed Feb 22 11:14:21 2023 -0500 feat: implement a11y `aria-activedescendant-has-tabindex` (#8172) #820 commit a71b8b99585bd636dd0e3ea250c9a092afb0533d Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Wed Feb 22 16:18:36 2023 +0100 chore: improve parser performance (#8303) - fast path for attribute quote marks common case - all regexes exclusively passed into read or match_regex which are only successful if matched at the beginning are altered so that the regex has this condition built in, preventing it from searching past the start index --------- Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit e3e912ab58033c8f4e2b669bc923e2ce30134b8f Author: brunnerh <brunnerh@users.noreply.github.com> Date: Wed Feb 22 09:51:26 2023 +0100 Fix accessibility of options tutorial. (#8308) Use button instead of non-interactive element (div). (Removes a Svelte a11y warning.) commit a0cedf8d82279113ef86ebc4dc77b6ec6cb609db Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Wed Feb 22 17:46:49 2023 +0900 fix: flush remaining `afterUpdate` before `destroy` (#7516) fixes #7476 commit 57d869d0289e24bf564ad76b62597846d27c4611 Author: Rémi Marche <35939574+ecstrema@users.noreply.github.com> Date: Tue Feb 21 20:00:15 2023 +0100 [docs] move `@html` tutorial to end (partly fixing #7253) (#7254) * Move @html tutorial to end * move debug and html tag into one section * rename --------- Co-authored-by: Rémi Marche <35939574+Marr11317@users.noreply.github.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> commit 87424b3137557ac33479d7c814c017b546b6464b Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Feb 21 18:14:15 2023 +0100 chore: update changelog commit aa9b2dd5f3c54ae9918ec6659760cfaf1f7d8892 Author: Carlos Ivanchuk <105121122+buhodev@users.noreply.github.com> Date: Tue Feb 21 12:27:49 2023 -0400 fix: omit a11y warning on `<video>` when `aria-hidden="true"` (#7880) Related to #5967. Closes #7874 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 2a5b48838648305b933de9d9ab5c9654ca24848a Author: Valter Kraemer <valterkraemer@users.noreply.github.com> Date: Tue Feb 21 16:21:48 2023 +0200 fix: empty value attribute selector doesn't produce "Unused CSS selector" warning (#8122) Fixes: #8042 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit f6ef6a9349a04cc8cab1dbb091c34621a2eace8f Author: Ben Bucksch <1907525+benbucksch@users.noreply.github.com> Date: Tue Feb 21 13:52:39 2023 +0100 fix: don't throw when calling writable() unsubscribe twice (#8186) Fixes one case of #4765 --------- Co-authored-by: Ben Bucksch <bbucksch@jw.org> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 85f882f23dda881c2478f7828a82065aca6bbeb7 Author: Jhorman Ruswel ㅠㅠ <jhormanrus@gmail.com> Date: Tue Feb 21 07:13:50 2023 -0500 docs: update Keyed Each Blocks tutorial (#8188) log which element is removed --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit 324b791d81203546d11af2a3d1062353c1b5b8b7 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Feb 21 13:04:12 2023 +0100 docs: note #if to wrap text only taken from #7070 commit 213049cc2e6dfddb872c2286a2a8e5f00c22d73e Author: Hyunbin <47051820+hyunbinseo@users.noreply.github.com> Date: Tue Feb 21 20:07:33 2023 +0900 docs: update dialog example (#8200) * feat: update dialog example * button always autofocusses, allows us to simplify --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit 7a6eee51e02c59cb2ae9d6276c19531ccf7fee6c Author: Mike Plummer <mike-plummer@users.noreply.github.com> Date: Tue Feb 21 04:54:00 2023 -0600 docs: Expand testing FAQ section (#8205) --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> commit 4dd12c0c61c647a9c5fafc4bde05c1bf7bcb8c1c Author: Maxime Dupont <m.dupont103@gmail.com> Date: Tue Feb 21 11:33:01 2023 +0100 docs: fix fly animation description (#8236) commit d5e46d647ee3f16945c3f475c8265f2e3e121875 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Feb 21 11:24:53 2023 +0100 chore: update changelog commit b0fed256f71aeaed9a0dac3cde81f6d98ee0724b Author: Andrew Walker <axwalker@users.noreply.github.com> Date: Tue Feb 21 10:23:13 2023 +0000 feat: Add -replacestate/-keepfocus to SvelteKit anchor tag props (#8281) commit 5a3a1e488a2df94c1d56a04429015ad7125b9b23 Author: Lioness100 <jchickmm2@gmail.com> Date: Tue Feb 14 13:36:48 2023 -0500 fix: correct typos in variable names (#8257) Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> commit acba4b72e23c90939ca8c39a22aca185d588aa1b Author: James Scott-Brown <james@jamesscottbrown.com> Date: Tue Feb 14 18:04:49 2023 +0000 docs: clarify bindings for `<select multiple>` (#8260) Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> commit d9253963f79d2066edd164580a684cd066042638 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Feb 14 09:05:19 2023 -0800 Bump qs from 6.5.2 to 6.5.3 (#8090) Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](https://github.com/ljharb/qs/compare/v6.5.2...v6.5.3) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0598c989a03f1a5c7b67f2dac9dc09de7c42c34a Author: Alicia Sykes <alicia@omg.lol> Date: Tue Feb 14 16:57:07 2023 +0000 docs: corrects syntax error in transition code sample (#8169) Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> commit d7e4b1c8fc91bbfc53d72165cc80390502540313 Author: Kyrre Gjerstad <98534972+kyrregjerstad@users.noreply.github.com> Date: Tue Feb 14 17:25:23 2023 +0100 docs: fix minor typos (#8268) Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> commit ff5c14dc71ead7834b6f0ce3ee8f63f6185ce777 Author: James Scott-Brown <james@jamesscottbrown.com> Date: Tue Feb 14 16:19:57 2023 +0000 docs: format `window.navigator.onLine` reference as code (#8262) commit 7706a5f7138ef07bfc67a8366f910427994a087f Author: James Scott-Brown <james@jamesscottbrown.com> Date: Tue Feb 14 16:18:06 2023 +0000 docs: link to MDN page on void elements (#8261) commit 82d2982845df188631993db6b18c2842e3613acf Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sun Feb 5 06:20:51 2023 -0800 chore: update PR template (#8255) commit 6ac24f1d5c9174b161bb6e27743c84c0a117ea7f Author: Satvik <satvikgsu@gmail.com> Date: Sun Feb 5 07:00:54 2023 -0500 [docs] add missing semicolon (#8190) commit cb972ecdba92326e67c6cc37f672c58b88fdc3a5 Author: Tim McCabe <me@timmcca.be> Date: Sun Feb 5 06:23:43 2023 -0500 [chore] fix `a11y-no-nointeractive-tabindex` typo (#8252) commit e875a76ad1675c21aea0911a8b32c8ad3abc070b Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat Jan 28 08:51:35 2023 -0800 update changelog commit 34ae6aaf1f3279e2c0f0515f64db59d31ecb46f9 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat Jan 28 08:50:14 2023 -0800 fix: make `noreferrer` warning less zealous (#8230) Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit eb90a15c2959d0d02ee27b4920dc1f197b77b70a Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri Jan 27 16:27:19 2023 -0800 update changelog commit 4f42daeff78a98877d58dff49b6e05b3a4ae0f73 Author: Jay Harris <jay.harris@outlook.co.nz> Date: Sat Jan 28 13:25:04 2023 +1300 feat: `trusted-types` CSP compatibility for Web Components (#8135) commit 79fa5b36a1b0d90407d1bf6b1d6b2504427f3f96 Author: Gabriel Francisco <gabrinelson27@gmail.com> Date: Fri Jan 27 13:22:52 2023 -0300 Update license year (#8227) commit 967e9f51ff649f776fa034db8aba23a5a1546294 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Thu Jan 12 11:11:14 2023 +0900 chore: add Node18 for CI (#8078) commit 3b3e1c839c9991559547ca3e203d2282d4f90c36 Author: Conduitry <git@chor.date> Date: Tue Jan 10 12:17:09 2023 -0500 -> v3.55.1 commit 492d7d6f67ba3a065651f860fdcca477df0d1d04 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Jan 10 09:41:59 2023 +0100 update changelog commit b06e4356848ab3375797e634fd6c6114a9643252 Author: Emil Tholin <emtholin@gmail.com> Date: Tue Jan 10 09:39:50 2023 +0100 [fix] Spread component props immutably during SSR (#8176) By passing an empty object literal as first argument to Object.assign we can avoid having objects spread as props on a component being mutated during SSR. Fixes #8171 commit aa98397440baa06743cead6a2955e98b75ee4515 Author: Josh <44098505+josh-fnbtech@users.noreply.github.com> Date: Tue Jan 10 02:38:47 2023 -0600 [docs] fix typo (#8180) commit be38cec3c10b83f76450c9125fa778c8af6453f7 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue Jan 10 09:38:16 2023 +0100 update changelog commit 7e6acbece31fbd68e2c07e37f3c849c405eb6983 Author: Chris Reade <christopher.reade@gmail.com> Date: Tue Jan 10 00:36:51 2023 -0800 [fix] Adding part HTML attribute to typings (#8182) fixes #8181 commit f0dcf1416ccf3dbc53d0684df16ed4f79917b103 Author: cunzaizhuyi <877824709@qq.com> Date: Tue Jan 10 00:37:28 2023 +0800 [chore] shorten import statement (#8178) commit 1f8e53a37ff8dba1d8001709e9ac809dca07f73a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 9 08:35:13 2023 -0800 Bump json5 from 1.0.1 to 1.0.2 (#8175) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit dd11917fe523a66d8f5d66aab8cbcf965f30f25f Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Tue Jan 3 12:49:02 2023 +0900 Update CHANGELOG.md commit 4b84c4df3a8c07f0a992e255350eb97db36c5cf6 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Tue Jan 3 12:48:06 2023 +0900 [fix] Improve `is_promise` handling (#8162) * correctly handle promises that are of function type * add License Co-authored-by: Vilsol <me@vil.so> commit e1a1c7fa87aca46d5cf5ac68596df01631da585d Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Jan 2 15:55:14 2023 +0900 [chore] Fix CI (#8160) * ci build * fix test * add test for #7938 commit 26c0d3f17d067fa5eab6e980dbeda5733b8998dd Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Jan 2 15:47:14 2023 +0900 Update CHANGELOG.md commit 762d0429b1fd2c3743fe7836108b3c1c557db750 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Mon Jan 2 06:51:01 2023 +0100 [fix] propagate bindings correctly (#8114) Fixes #8103 introduced through #7981 Keeps the infinite loop from happening but reopens #6298 and #5689 commit 1d658e75012a361de6f6ae841995d423fb8d4e30 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Jan 2 10:51:01 2023 +0800 Update CHANGELOG.md commit c9e98e6bbaed9b33df8087567235de9a54fdc537 Author: Mathias Picker <48158184+MathiasWP@users.noreply.github.com> Date: Mon Jan 2 03:48:34 2023 +0100 [fix]: remove double up initialization on svelte:element (#8142) * fixed double up initialization on svelte:element elements * updated test and fixed bug * update other svelte:element test * removed whitespace * refactor * correctly update expected ouput resulting from #7938 * remove .solo Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 14d09a085036858de93148d283e4096d3cd39e53 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Jan 2 10:26:58 2023 +0800 Update CHANGELOG.md commit 1f021226c5df92e0685cce806918b8953e521a2a Author: Ming07 <q502489978@live.com> Date: Mon Jan 2 10:23:35 2023 +0800 [fix] named slots breaks svelte-ignore comments (#8105) * [fix] Named slots breaks svelte-ignore comments Fixes #8075 * test: add tests * refactor * refactor test Co-authored-by: mojinming <mojinming@cmcm.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 4f365f017174c3f9356c9987204e7f760aafcb13 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Jan 2 10:20:38 2023 +0800 Update CHANGELOG.md commit a5d6713c8edff97bdcc01b4dda13c16579294acf Author: Gus Wezerek <gwezerek@gmail.com> Date: Sun Jan 1 19:18:52 2023 -0700 Fix bug with transition draw when delay is passed (#8094) Signed-off-by: Gus Wezerek <gustav.wezerek@nytimes.com> Signed-off-by: Gus Wezerek <gustav.wezerek@nytimes.com> Co-authored-by: Gus Wezerek <gustav.wezerek@nytimes.com> commit 094483b397829d2c7633f7f6bc278e5ecfd0868a Author: wackbyte <wackbyte@pm.me> Date: Mon Jan 2 01:39:55 2023 +0000 [fix] say "nonnegative" instead of "positive" tabIndex for `a11y-no-noninteractive-tabindex` (#8126) commit 06648d1f65ff9a9fc8392dd5c49ab5753b20abce Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Sun Jan 1 16:43:46 2023 +0800 Update CHANGELOG.md commit f84c00edb9aab75c939963332da57af0e82894f3 Author: Ramon Snir <r@mon.dev> Date: Sun Jan 1 03:41:00 2023 -0500 [fix] static svelte:element not replaced with tag in production mode (#7938) * [fix] static svelte:element not replaced with tag in production mode * [fix] static svelte:element not replaced with tag in production mode * add optimization of static <svelte:element> and fix a bug Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit de6821a1de6574b1aa987944fe9a5f0b5f7724bb Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Sat Dec 31 10:13:52 2022 +0900 [ chore] disable puppeteer on Linux for Node8 and 10 (#8155) commit b8f32c0b1a295fd56c7c04683402968f32f01597 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu Dec 22 17:47:52 2022 +0100 [docs] clear timeout on destroy backported from https://github.com/sveltejs/learn.svelte.dev/pull/166 commit 786505d6bc52ce9ad072f1c44cacfeb4f3bd58ab Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu Dec 22 13:13:31 2022 +0100 update changelog commit c73b9a00ea64bcf2565bc224fd6e3afc760cc0fc Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu Dec 22 13:08:06 2022 +0100 [fix] add submitter property to submit event commit 6a23d9b65f3a1716c9669d88553393c71bbce673 Author: Geoff Rich <4992896+geoffrich@users.noreply.github.com> Date: Wed Dec 21 16:39:36 2022 -0800 [docs] fix transition direction options (#8133) commit b8bc1be0a8bc4f5cf9e78fa44ae7e22e724dc985 Author: Rich Harris <richard.a.harris@gmail.com> Date: Tue Dec 20 11:09:50 2022 -0500 remove blog content. it now lives in sites repo (#8117) commit eef125f6c1d586ec4ed4a75ae8a93c54870a2e12 Author: gaac510 <74474003+gaac510@users.noreply.github.com> Date: Tue Dec 20 08:47:31 2022 +1100 [docs] update outdated SvelteKit release info (#8128) Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> commit 670f4580568fe8ea31097981ba2d59c33daf0725 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Fri Dec 16 10:33:36 2022 +0100 [docs] adjust code snippet to conform with previous one Backported from https://github.com/sveltejs/learn.svelte.dev/pull/143 commit ad8dbfb9b923182872f781210b6c69beff6a2a24 Author: Nilesh <19304+nileshtrivedi@users.noreply.github.com> Date: Thu Dec 15 12:47:02 2022 +0000 [docs] Add comment about generating a Svelte project without Kit (#8115) commit 3ba0e304166f7d5dfc608fdf2696a8f4cbc2b4f0 Author: Conduitry <git@chor.date> Date: Tue Dec 13 09:04:08 2022 -0500 -> v3.55.0 commit 512eda7a84c342b2798b2e5cffcd16068744d798 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Sun Dec 11 21:45:11 2022 +0100 [feat] add html typings (#7649) This adds typings for HTML elements and their attributes. It's supposed to be used by the new transformation in language-tools. Co-authored-by: Ignatius Bagus <ignatius.mbs@gmail.com> Co-authored-by: Lyu, Wei-Da <36730922+jasonlyu123@users.noreply.github.com> commit a0a6bd1f546096d9e5cac8edbec7b21d5f2d580e Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Wed Dec 7 11:04:50 2022 -0800 [docs] add some basic docs about bundler plugins (#8092) commit aa5a1cdf1a21845f8d174ebadee76564394daa81 Author: Conduitry <git@chor.date> Date: Tue Dec 6 14:25:16 2022 -0500 -> v3.54.0 commit 86524181a9b825ad2a49f3af52f501950ea627ba Author: Conduitry <git@chor.date> Date: Tue Dec 6 14:24:27 2022 -0500 update changelog commit 94e51df07b0512de0716a0109d29c8a1d1f1ce20 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Wed Dec 7 04:23:23 2022 +0900 [fix] escape style attribute for SSR (#8087) commit 75c3a48245295c3748a135165a4ac9947bf11ef8 Author: Conduitry <git@chor.date> Date: Tue Dec 6 14:22:36 2022 -0500 update changelog commit cc52dc442be8cb3207005d13bf9b1d521b2b0afd Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Tue Dec 6 00:18:29 2022 +0900 [docs] add explanation about property binding order (#7833) * update document * update sentence and position * update the sentence * update commit f45b8237704573fb736bd40cf7751063f61deb91 Author: Daniel Huang <99danielh@gmail.com> Date: Mon Dec 5 10:14:11 2022 -0500 [docs] fix inconsistent margin in svelte/motion spring tutorial (#8081) commit d8c6ab87df1edf28e7a286818434bda8443d3f15 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Tue Dec 6 00:02:21 2022 +0900 Update CHANGELOG.md commit 2f61907ec136eb53528a2933b194689b98e444aa Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Dec 5 23:01:51 2022 +0800 [fix] allow invalidating variables from @const declared function (#7858) commit 5eb1ff9946a6a1ac2d1de838f1911cceab3723c7 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Mon Dec 5 06:53:29 2022 -0800 [docs] publish roadmap. add process section to contributor's guide and re-organize a bit (#7965) commit 43905ccc22e0875f39a3e8d9317d8a75cdf974d5 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Dec 5 23:52:30 2022 +0900 Update CHANGELOG.md commit 4c5469b1ee55a9675240adaab5bb42ae8b7c3f3f Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Mon Dec 5 15:43:39 2022 +0100 [fix] don't run binding init unnecessarily (#7981) commit d2ff2aee4f6269868099dae42472c1be00d24576 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Dec 5 23:25:55 2022 +0900 Update CHANGELOG.md commit ed3ac92ec075dc237de2994c7f5f9a38819fd79c Author: Bert B <44912991+bertybot@users.noreply.github.com> Date: Mon Dec 5 09:25:25 2022 -0500 [fix] Suppress `a11y-no-noninteractive-tabindex` warning if an element has a `tabpanel` (#8025) * update tabindex warning to ignore tabpanels * refactor Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit de46e36315322f9785bb88cd0f3e78e42fd765c3 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Dec 5 23:01:14 2022 +0900 Update CHANGELOG.md commit 676716979a95bf33333a2ba8185ceea63e7d7655 Author: Torsten Dittmann <torsten.dittmann@googlemail.com> Date: Mon Dec 5 15:00:51 2022 +0100 [fix] a11y - allow fallback roles (#8045) commit 6330bfc05285f945b750a3d78f28b7994d2a2e13 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Dec 5 22:44:40 2022 +0900 Update CHANGELOG.md commit 84d61c61f883c206b87a6fc76c5690379059f979 Author: Pat Cavit <github@patcavit.com> Date: Mon Dec 5 05:43:59 2022 -0800 [feat] Add options w/ direction to transitions (#8068) commit 14f33cfe6191f63b9ac3f6d4b273c67b1cdec955 Author: Sanguansak Petchmeesri <nguansak@gmail.com> Date: Sat Dec 3 22:42:34 2022 +0700 [docs] add rel noreferrer to fix warning in tutorial (#8024) Co-authored-by: vaishnav <vaishnav240204@gmail.com> Co-authored-by: Alfredo Vecino <fredovecino@gmail.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com> commit 8b462fd7da8d6d0c43f5a208f4dfaa0923540769 Author: Janosh Riebesell <janosh.riebesell@gmail.com> Date: Sat Dec 3 06:55:51 2022 -0800 [docs] Fix 3.52.0 a11y warning in svelte-self tutorial (#7988) * fix svelte 3.52 a11y warning * replace span with button and drop on:keyup commit 6923b2e99b901d23808f014c6bfbced889f949bf Author: Frozen FIsh <76603360+sudongyuer@users.noreply.github.com> Date: Sat Dec 3 22:42:07 2022 +0800 [chore] upgrade node to 18 (#8018) commit e44762aa2d5a7fde6371c45ff3c212eae912f57b Author: Simon He <57086651+Simon-He95@users.noreply.github.com> Date: Sat Dec 3 14:54:32 2022 +0800 [chore] add ESLint Caching (#8069) see: https://eslint.org/docs/latest/user-guide/command-line-interface#caching commit e86c0c610bc277180dd95e15c5c130ed8cf9bc9b Author: Christian Bromann <git@bromann.dev> Date: Sat Dec 3 06:03:45 2022 +0100 [docs] Add WebdriverIO as alternative testing solution commit 1852bc4640d70d4ff2b4893d49dca31bb3542ba5 Author: Dani Sandoval <daniel@desandoval.net> Date: Fri Dec 2 03:48:30 2022 -0700 [docs] "What's new in Svelte" December newsletter (#8064) commit 91f8764145f2c2b3c30bfec5a3b409df8e0ddcc9 Author: Conduitry <git@chor.date> Date: Thu Nov 10 09:15:07 2022 -0500 -> v3.53.1 commit e48fa4ac29bdeee7ee3cdb2eb2601028ae66b49a Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu Nov 10 15:10:40 2022 +0100 [fix] util polyfill to make compiler self-contained (#8014) this is needed for running the Svelte compiler in the browser Fixes #8010 commit f4779eee4a855fac5aa18c1c6e568f14b6ef1643 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu Nov 10 15:10:09 2022 +0100 [fix] don't emit css option deprecation warning for now (#8012) commit ee480bded663e3e345332da4a9cce53dd4ede9fb Author: Dominik G <dominik.goepel@gmx.de> Date: Thu Nov 10 14:00:08 2022 +0100 [fix] only read static value for rel attribute validation (#8003) fixes #7994 commit ea219f4ed83883d4354e7f13c0749ba300e3e130 Author: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Date: Thu Nov 10 17:39:25 2022 +0545 [chore] patch bump tslib (#8015) closes #8013 ref: microsoft/tslib#160 commit b2d36075aeb5a9110caa66d2d383d44befcf00b8 Author: Conduitry <git@chor.date> Date: Wed Nov 9 16:51:48 2022 -0500 -> v3.53.0 commit 80d4f55a061e1ddfdfa28a9c2762d6e776ec8727 Author: Conduitry <git@chor.date> Date: Wed Nov 9 16:24:27 2022 -0500 update changelog commit 74fdbb670ba426484c6d22a3c30fe798d97bf6e7 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Wed Nov 9 10:25:25 2022 -0800 update changelog commit 92f02669cf762c57a18ba7f33a20683494a3c495 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Wed Nov 9 10:22:25 2022 -0800 [chore] upgrade dependencies (#7982) commit 773dedf714fcf895429e53920e5c013a8b86f411 Author: Maximiliano Ruani <maxi.ruani@hotmail.com> Date: Wed Nov 9 15:21:38 2022 -0300 [feat] Compiler option css: 'none' support (#7914) commit b05b684b95a5670968f83ae6868881f2231afa74 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Mon Nov 7 13:09:53 2022 +0100 Update changelog commit 84ea242666174a405d27a46e19d148d1ef622875 Author: byt3r <glevin2@gmail.com> Date: Mon Nov 7 14:09:01 2022 +0200 [fix] check parentNode exists before removing child (#6910) Fixes #6037 commit d39920fb102a66e0bc4301c7dd633ea748648e60 Author: tomoam <29677552+tomoam@users.noreply.github.com> Date: Mon Nov 7 18:15:25 2022 +0900 [docs] fix link in November newsletter (#7998) commit bba3ffed0e7ed0c417df0cb8414eea2b96758a8a Author: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Date: Thu Nov 3 09:43:39 2022 +0100 [chore] Update link to feature request template (#7992) commit df2e927b46b9d8b44ab39203dea02e3a28d04608 Author: Daniel Sandoval <daniel@desandoval.net> Date: Mon Oct 31 14:20:54 2022 -0600 [docs] "What's new in Svelte" November newsletter (#7986) Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> commit b265bc6f0fb4d981827fc1dbb89185076a9f3885 Author: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu Oct 27 11:09:18 2022 -0400 [chore] fix spelling and typos (#7974) commit 146e7a6310627d4599bb60760d573dffa5d1d2ce Author: Neagu Mihai <74415486+devneagu@users.noreply.github.com> Date: Thu Oct 20 21:04:35 2022 +0300 fix: Remove Security Message (#7959) commit 0a7cf0e73e386e46a692e06d540703c435d4d003 Author: Josiah Nieves <23145687+jtn7@users.noreply.github.com> Date: Sun Oct 16 22:45:03 2022 -0400 [docs] fix typo "bellow" vs "below" (#7955) commit f9e5b3e995a488ff5ef21b4258a5954ea6667dbf Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Sun Oct 16 17:01:12 2022 +0800 Update CHANGELOG.md commit 8921c04a21e60bf6773cded17e79fde016c1018a Author: Sid <vistax86live@gmail.com> Date: Sun Oct 16 14:28:34 2022 +0530 [chore] Upgrade css-tree version to 2.1.0 (#7572) * chore: upgrade to css-tree major version * fix: handle whitespace token for new ast * fix: css syntax error * remove @types/css-tree * import css-tree/parser instead of file path import Co-authored-by: tanhauhau <lhtan93@gmail.com> commit 1de2c025350511c4be27a784d7a295b17727692f Author: Yuri <yurivish@gmail.com> Date: Sun Oct 16 04:25:39 2022 -0400 Ensure onmouseleave event fires in Hoverable example (#7873) Fixes the browser-quirk-related issue described in #6520 and #7867, based on a [suggestion](https://github.com/sveltejs/svelte/issues/7867#issuecomment-1248993436) by @Prinzhorn. Tested in the editable example area on the Svelte site: https://svelte.dev/examples/slot-props commit caca8a53401e975d23672255393dd778a58a48ff Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Sun Oct 16 13:55:23 2022 +0900 [chore] Improve CI (#7945) * stop to use cache * update on.push.branches * rename commit ef849217c43e157863dd0a7996ad56e1084b150b Author: Conduitry <git@chor.date> Date: Sat Oct 15 09:57:24 2022 -0400 -> v3.52.0 commit 244d74d4a752e8ec768a9323d88257dcf9bee202 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Fri Oct 14 20:08:25 2022 +0800 [feat] pre-build before testing in CI (#7933) commit a6169f65ebf84634908d23c20f1e562742dd338b Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Fri Oct 14 14:15:28 2022 +0900 Update CHANGELOG.md commit e8b4997bb53134d96c736833ecffeee083b5689d Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Fri Oct 14 13:15:04 2022 +0800 [fix] duplicate meta tags during hydration (#7941) commit bb83eddfc623437528f24e9fe210885b446e72fa Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Oct 13 22:25:39 2022 +0800 Update CHANGELOG.md commit 88ed9931f22f4d1cd19c297a6686cc497c65f67a Author: Billy Levin <billy.levin97@gmail.com> Date: Thu Oct 13 15:23:07 2022 +0100 warn on assignment to const (#4960) * warn on assignment to const * fix formatting and switch to error * check most local scopes first * fix logic and add more tests * more formatting * Fix broken test * use find_owner instead Co-authored-by: tanhauhau <lhtan93@gmail.com> commit ab1285a4f80cffde46e4d54d45018e95c9a35a03 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Oct 13 21:59:07 2022 +0800 Update CHANGELOG.md commit c7c6c05c7f891a864f888f14b5770c467970feac Author: Joffrey LEVEUGLE <joffrey.leveugle@gmail.com> Date: Thu Oct 13 15:58:10 2022 +0200 [feat] add security warning for anchor element (rel attribute) (#6289) * add security warning for anchor element (rel attribute) * manage more case for security warnings on anchor (aplocks, false positive ...) * remove noopener checks as noreferrer imples noopener Co-authored-by: tanhauhau <lhtan93@gmail.com> commit ea9ee3911f06f76f7c31a0f72aab737adf674f6f Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Oct 13 21:53:23 2022 +0800 Update CHANGELOG.md commit bee1851faa9c2a8b39099299a7929ebfe9c25494 Author: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Date: Thu Oct 13 19:37:06 2022 +0545 [feat] `|important` modifier for style directive (#7489) * important modifier for style directive * docs * Exclude third param if false third param for set_style is optional * Remove unused test Runtime test doesn't work because of weird behaviour of computed style the puppeteer test should cover it * remove unnecessary test Co-authored-by: tanhauhau <lhtan93@gmail.com> commit ff6e1c39d0ff783a06a2303328a7360d2206b778 Author: Siarhei <siarhei.krukau@gmail.com> Date: Thu Oct 13 15:51:06 2022 +0200 [chore] Bump actions' versions (#7921) commit 1ca83c20506d7b4c97a921d98c21fc564f8efa16 Author: Don Alfons <donalfonsnnisnoni@gmail.com> Date: Thu Oct 13 21:01:58 2022 +0800 [docs] Improve grammar (#7923) * [docs] Improve grammar * revert spelling changes Co-authored-by: tanhauhau <lhtan93@gmail.com> commit 739bfaec1285e9be1301f9dbc26551c79c61c2d8 Author: Hofer Ivan <ivan.hofer@outlook.com> Date: Thu Oct 13 14:56:09 2022 +0200 [chore] add missing types to `compiler/compile/render_dom` functions and variables (#7777) * add missing types to `compiler/compile/render_dom` functions and variables * add `DetachingOrNull` * fis `is_head` commit 0eba57113be4185836a76ba894cbc29f366da252 Author: Hofer Ivan <ivan.hofer@outlook.com> Date: Thu Oct 13 14:54:30 2022 +0200 [chore]: store regexp as variable instead of defining it inline (#7716) * store regexp as variable instead of defining it inline * fix naming of `regex_quoted_value` * some more variables * optimize `.replace() calls * restore formatting changes * optimize `parser.*` calls * small refactor * optimize `.test() calls * rename some variables * fix tests * rename pattern variables * extract common regexes into `patters.ts` * rename variables to use snake_case * fix trim commit 26a428972b7865d3871e05368df5e7b47bbf7e5b Author: metonym <ericyl.us@gmail.com> Date: Thu Oct 13 05:49:00 2022 -0700 [fix] "not interactive" -> "noninteractive" (#7930) commit 6ac7038e47c38221f16f0f73af93c9024ff2a18c Author: Conduitry <git@chor.date> Date: Mon Oct 10 13:15:45 2022 -0400 -> v3.51.0 commit 1c659193a0b1fdf6e472be182fb600a430784d20 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri Oct 7 16:34:31 2022 -0700 [docs] update SvelteKit status (#7919) commit ff2759e1437559669bd032abaff6920c2fc46570 Author: Geoff Rich <4992896+geoffrich@users.noreply.github.com> Date: Fri Oct 7 16:25:19 2022 -0700 [docs] fix typo in getting started (#7918) commit 220325cd9feea12f9a9bc5eb8df5120f856b1bc9 Author: Samuel Stroschein <35429197+samuelstroschein@users.noreply.github.com> Date: Fri Oct 7 11:11:46 2022 +0200 [docs] add inline documentation to svelte runtime functions (#7846) * add documentation * add links do docs commit 2b7393885724ed158dd3ce1b9e53b9737a5f3c3e Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Fri Oct 7 08:25:04 2022 +0800 Update CHANGELOG.md commit 8de7931c64b46d22fc303adce14eb3f680c8ca66 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Fri Oct 7 08:23:12 2022 +0800 [feat] better error message for invalid logic block placement (#7862) * better error message for invalid logic block placement * include checking for {@html} tags in invalid location commit d04b1cca24fdfb9f170d0a5f747d94eabe7ee22b Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Thu Oct 6 23:30:42 2022 +0900 Update CHANGELOG.md commit 158ec43d99376ccb70c374e306552151b1dbf63b Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Oct 6 22:29:48 2022 +0800 [fix] do not warn about missing props for bindings (#6583) commit ce569f97ebd633d44c747cef8039725325c7d753 Author: Marcos Mercuri <marcos@rillet.io> Date: Thu Oct 6 11:23:29 2022 +0200 [docs] Add clarification on how reactivity works (#7819) * Add clarification on how reactivity works Based on the fact that there are multiple issues were opened related to a perceived bug on the reactive variables, I thought it would be good to add a clarification on the docs. Part of the text is taken from [this comment](https://github.com/sveltejs/svelte/issues/7818#issuecomment-1230374639) that I found super useful. * Reword based on PR comments commit bfb7536c1a6718babc21c869070ff94de484c946 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Thu Oct 6 10:28:41 2022 +0900 Update CHANGELOG.md commit 81d4dbad99f2c349ced55c65f7ac2db704a771f6 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Oct 6 09:21:36 2022 +0800 [fix] call `on_destroy` if unmounted called immediately before `on_mount` (#7860) * call on_destroy if unmounted called immediately before on_mount * feat: review changes commit 57541e6abc3837c07019a468d32ef74552bf2677 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Thu Oct 6 01:21:31 2022 +0900 Update CHANGELOG.md commit 5c5bc27d9782039259ce8ffca3eb1673f22396c5 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Thu Oct 6 00:18:37 2022 +0800 [feat] Support style props for SVG components (#7859) commit ea2f83adebd0a656fae72200525f6e4a1259701f Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Wed Oct 5 23:29:43 2022 +0800 Update CHANGELOG.md commit 01a91163a9ffd6d18ea4699cef4c531b72fbfc00 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Thu Oct 6 00:28:00 2022 +0900 [fix] Improve error message if `this` attribute of `<svelte:component>` is not valid (#7551) * add test * improve error message if this attribute of <svelte:component> is not SvelteComponent * add more tests * improve validation * simplify test Co-authored-by: Tan Li Hau <tanhauhau@users.noreply.github.com> commit be70a898f392149aa5910bc000a0a55b85ba7f9a Author: Shawn <62589492+laazyCmd@users.noreply.github.com> Date: Wed Oct 5 14:44:08 2022 +0000 [docs] fix link redirect to discord (#7911) * fix link redirect to discord * fix link redirect to discord commit 7d20194d8ae9b600936e47826de53eb4f75e58e1 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Tue Oct 4 21:38:58 2022 -0700 [docs] create getting started guide outside blog (#7812) commit a752ef4709587851b783137997c7457fadd2ddb6 Author: Alex <aleksandrosansan@gmail.com> Date: Tue Oct 4 00:34:10 2022 +0300 GitHub Workflows security hardening (#7883) commit 0b46c72cada210b3a6c72c30a51d35f5c4ccefb3 Author: Daniel Sandoval <danielericsandoval@gmail.com> Date: Fri Sep 30 11:57:42 2022 -0600 [docs] "What's new in Svelte" October newsletter (#7898) Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: Lyu, Wei-Da <36730922+jasonlyu123@users.noreply.github.com> Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com> commit c12704c3014f71741aa707700c32a42df699f8e6 Author: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Wed Sep 28 16:51:45 2022 +0200 [fix] typings for #7863 commit ee5479d00eadc47ecb38446a5dcfcaea043774f9 Author: Xiao Chuan <w2239559319@outlook.com> Date: Thu Sep 22 23:25:04 2022 +0800 [fix] fix ctx and dirty type (#7832) * fix: ctx type * fix: update function dirty type commit 132dbecc584fe84154f2acf9ee02e620285ce299 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Wed Sep 21 21:49:12 2022 +0800 Update CHANGELOG.md commit b20fb114a657abcd63a79d25789428258f952b3a Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Wed Sep 21 21:48:01 2022 +0800 allow nullish values for component event handlers (#7863) commit 25a05bf952579423b31582ee085388ce0be140cb Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Thu Sep 15 22:26:15 2022 +0900 update changelog commit 433460ec2dab0b44deeefc52c03358a0b60df335 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Thu Sep 15 22:22:40 2022 +0900 [feat] skip custom element check if <svelte:element> uses under svg (#7869) * add test * skip custom element check if svelte element uses under svg commit 56bcec5ddd4dbded644582c970f4a04e45941217 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Tue Sep 13 23:57:13 2022 +0800 Update CHANGELOG.md commit 5adac302c0400363ed5da83c6730ff3379b81d2e Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Wed Sep 14 00:56:19 2022 +0900 [fix] call attribute bindings for custom element if <svelte:element> render custom element (#7766) * call attr bindings if tag is custom element * add test commit c113d9d978da46d628b4d4ae19d28c275130df06 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Tue Sep 13 23:55:22 2022 +0800 Update CHANGELOG.md commit 980aff8a4aaf91677f045e757949ecc3be6605b2 Author: metonym <ericyl.us@gmail.com> Date: Tue Sep 13 08:44:20 2022 -0700 [fix] omit a11y warning for native checkbox/radio inputs (#7838) * [fix] omit a11y warning for native checkbox/radio inputs Fixes #7837 * align implementation with eslint-plugin-jsx-a11y Co-authored-by: tanhauhau <lhtan93@gmail.com> commit d7cfe22f3702af28334a541f204eafe7f0c0d9db Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Tue Sep 13 21:40:09 2022 +0800 Update CHANGELOG.md commit 82013aa1610e9d8c73064e449d3b2c1304987896 Author: MCMXC <16797721+mcmxcdev@users.noreply.github.com> Date: Tue Sep 13 15:22:10 2022 +0200 feat(a11y): add click-events-have-key-events rule (#5073) * feat(a11y): add click-events-have-key-events rule Signed-off-by: mhatvan <markus_hatvan@aon.at> * Fine-tune click-events-have-key-events rule Signed-off-by: mhatvan <markus_hatvan@aon.at> * Implement PR feedback Signed-off-by: Markus Hatvan <markus_hatvan@aon.at> * Implement PR feedback Signed-off-by: Markus Hatvan <markus_hatvan@aon.at> * slight refactor to use existing utils * update docs * fix rebase conflicts Signed-off-by: mhatvan <markus_hatvan@aon.at> Signed-off-by: Markus Hatvan <markus_hatvan@aon.at> Co-authored-by: tanhauhau <lhtan93@gmail.com> Co-authored-by: dsfx3d <dsfx3d@gmail.com> commit 64690974dd37960d23ead5ee97b543abf2394bfc Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Tue Sep 13 19:22:02 2022 +0800 Update CHANGELOG.md commit e2538c594bb2fa3c12d06e9acfc592d6dc099d55 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Tue Sep 13 20:20:45 2022 +0900 [feat] support `--style-props` for `<svelte:component>` (#7468) * add test * support --style-props for <svelte:component> * refactor * add more test * support switching instance * add test with svelte:self * merge duplicated if statement * slight refactor * remove unnecessary anchor * reorder insertion Co-authored-by: tanhauhau <lhtan93@gmail.com> commit 75a7c3e68f8e2b9ca449c5ed1343f761966202e3 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Tue Sep 13 19:19:35 2022 +0800 Update CHANGELOG.md commit 899d0cc67ca8e8c18c747fb2906461c018498c70 Author: tanhauhau <lhtan93@gmail.com> Date: Tue Sep 13 19:16:58 2022 +0800 update docs for a11y-no-noninteractive-tabindex and rename from a11y-no-nointeractive-tabindex -> a11y-no-noninteractive-tabindex commit 2cd661156e3646b5b8c9e93f06e240f3613737e8 Author: Shinobu Hayashi <PhilisPaxil@gmail.com> Date: Tue Sep 13 20:10:45 2022 +0900 [feat] Add a11y rule to check no tabindex in nointeractive element (#6693) * [feature] add util module to check element is interactive element * [feature] add util module to check role is interactive role * [feature] add a11y checker for no-nointeractive-tabindex * [chore] add test for no-nointeractive-tabindex * [chore] fix tabindex-no-positive test div -> button * [refactor] bundle up two filter into one * Refactor: export a11y-no-nointeractive-tabindex warning from compiler_warning * slight refactor to use existing utils Co-authored-by: tanhauhau <lhtan93@gmail.com> commit 7331c06a74622a4635968a0c8d87b91fda4a1110 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Sep 12 03:30:02 2022 +0800 Update CHANGELOG.md commit 78b81277e7bbce3bad5f287312d22ce5dc339d2e Author: Vaibhav Rai <raivaibhav08@gmail.com> Date: Mon Sep 12 00:58:30 2022 +0530 [fix]: Warn user when binding rest operator (#7526) * Fix 6860: Warn user when binding rest operator * move the binding validation to Binding node * update test Co-authored-by: vaibhav rai <vaibhavrai@vaibhavs-MacBook-Pro.local> * add more test case, supporting deep destructuring and array destructuring Co-authored-by: vaibhav rai <vaibhavrai@vaibhavs-MacBook-Pro.local> Co-authored-by: tanhauhau <lhtan93@gmail.com> commit 87f0c461a84ae64ccd2d246e775b6deefc4150b9 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Sep 12 03:23:12 2022 +0800 Update CHANGELOG.md commit 6ec8ecf7999ad74ce8cf735a98adca630f9de105 Author: Mathias Picker <48158184+MathiasWP@users.noreply.github.com> Date: Sun Sep 11 21:22:17 2022 +0200 [fix] render of svg elements when using svelte:element (#7695) * fixed render statement for svg when using svelte:element * removed unecessary stuff in test commit 1afcfd2b5f30216164c582d703eb29a6ad4bd831 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Sep 12 03:15:45 2022 +0800 Update CHANGELOG.md commit e2ef2b8731a897b36d81d130c78cd4a9019aa41f Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Sun Sep 11 21:14:47 2022 +0200 apply class for dynamic elements (#7652) commit 78a249be36b1fa75a59755452554a531d0d4194a Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Sep 12 03:04:47 2022 +0800 Update CHANGELOG.md commit a5ca0ad65be5b79c51c9653f1ec16e84fbabba24 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Sep 12 04:03:02 2022 +0900 [fix] added support for inert (remove duplicated code) (#7785) * fix: added support for inert * remove duplicated boolean_attributes Co-authored-by: Gautier Ben Aïm <48261497+GauBen@users.noreply.github.com> commit 2f6afefab053a52b8dac31aee35635df837c8f61 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Sep 12 02:49:22 2022 +0800 Update CHANGELOG.md commit 1e2a55c88e753cefc6acc668c83fee6cdbc70f31 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Mon Sep 12 03:48:13 2022 +0900 throw warning instead of error (#7834) commit adcaa3c0503cacd7b61129bfebba8972cc49b661 Author: Tan Li Hau <tanhauhau@users.noreply.github.com> Date: Mon Sep 12 02:41:18 2022 +0800 Update CHANGELOG.md commit 8ffc8fd77bf667fdf41bb1f08ed4d1da6641320f Author: Maximiliano Ruani <maxi.ruani@hotmail.com> Date: Sun Sep 11 15:35:17 2022 -0300 [fix] Fix hydration duplicate `svelte:head` tag issue with `@html` expressions and nested components (#7745) * Fix hydration duplicate `svelte:head` tag issue with `@html` and nested components #7444 #6463 * - Changed comment style to HEAD_${head_id}_START and HEAD_${head_id}_END - Improved claim logic - Changed tests accordingly commit 7ac3854613ebad0b30a1d1b8dc0a2a34542a8de5 Author: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat Sep 10 14:00:50 2022 -0700 [docs] remove beta label from SvelteKit mention (#7853) commit 24aff3032d7af26162fb6a319b07131d21739e9c Author: Conduitry <git@chor.date> Date: Thu Sep 8 16:52:21 2022 -0400 -> v3.50.1 commit 07d6d179abb7fb86f45cd5175820bbb1c5cbf0e9 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Fri Sep 9 05:49:57 2022 +0900 [fix] style manager transition regression (#7831) commit ed078e31fe1d3594c105a17f7fb6def769b386f6 Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Sun Sep 4 19:08:46 2022 +0900 update changelog (#7835) commit feb8dfce61212affedfede786fd571dbd55905cb Author: Yuichiro Yamashita <xydybaseball@gmail.com> Date: Sun Sep 4 13:13:55 2022 +0900 [fix] add all global objects / functions (#7786) commit f3f3d074c59c79836a42f53ecd0cece3a916ef61 Author: schelv <13403863+schelv@users.noreply.github.com> Date: Sat Sep 3 18:06:57 2022 +0200 [docs] use KeyboardEvent.code (#7809) commit 46990652c00542c…
I'm working on an app that serves silent video. We have no use for an audio track inside of the video, so this warning doesn't even make sense in our context. |
I don't really agree with this warning either. Why are you assuming my video has words in it? You can't protect devs from every footgun. This is far more likely to be a false positive than a valid warning IMO. |
This warning has made me think about captions. I didnt even know you could have a track inside of a video tag. But in my case the warning is a pain because my video doesnt need a track and even if it did i wouldnt add it because i dont have the capacity to generate captions for all my videos. |
I'm rendering a camera output for a QR code scanner inside of an app. What caption would I even put? If there was one, It'd be the decoded qr code content, but that would be set dynamically, not in the markup (and would a11y technologies even support dynamically-changing Just chiming in with yet another use case where the video has no available captions, and making this an error instead of a warning makes my build fail. Making it a warning instead of removing it should not be done though, making devs aware of a11y issues is way too important - but making builds fail because of this is a bit much -- and empty tracks should definitely not be suggested tho |
I was just about to add that empty track line, before googling it just in case, and now I find out it could actually cause a bug instead. It seems to me that if you know you have captions available, you would most likely already be thinking how to include them, and therefore this warning only serves to introduce a bug, and not encourage accessibility. The only way I see that this benefits accessibility, is that the developer decides to create captions for the videos after seeing the warning, but considering how involved such a process is, that seems unlikely to happen if a warning is the only reason they would have for it. |
To reproduce. Open svelte repl or any svelte project, add
audio
orvideo
tag:Expected:
What actually happens:
A11y: Media elements must have a <track kind="captions"> (1:0)
Reasons this warning needs to be removed:
<track>
for<audio>
in any way whatsoevertrack
tags are not in any kind of widespread use<track kind="caption">
which linter wants people to addtrack
withoutsrc
- is not even valid according to spec! "The src attribute gives the address of the text track data. The value must be a valid non-empty URL potentially surrounded by spaces. This attribute must be present."alt
attribute onimg
which is meaningfully different from noalt
for historical reasons)The text was updated successfully, but these errors were encountered: