Remove misleading a11y caption warning on <audio> #6054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2021
dummdidumm
approved these changes
Jul 1, 2021
|
This has been released in 3.39.0 - thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5967 . Closes #6157
This PR removes the a11y warning for missing
<track kind="captions">on audio elements.The associated test has also been updated.
Merging this PR should not close the associated issue -- the intent of the issue was to remove the warning for audio and video, but there was some debate. Since there was clear agreement in removing the warning for audio elements, I thought to go for the quick win until consensus is reached around video captions.
Tests
npm testand lint the project withnpm run lint