Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: a11y media element examples:named-exports #5613

Closed

Conversation

izumiiii
Copy link
Contributor

@izumiiii izumiiii commented Oct 29, 2020

Fix: examples page: named-exports a11y

named-exports

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry
Copy link
Member

Thanks - could you also make the same change in the 'Sharing code' and 'Exports' tutorials as well please?

@izumiiii
Copy link
Contributor Author

@Conduitry
Done!

@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Jun 26, 2021
@stale stale bot removed the stale-bot label Jun 26, 2021
@pngwn pngwn added compiler Changes relating to the compiler stale-bot and removed feature: a11y temp-stale labels Jun 27, 2021
@stale stale bot removed the stale-bot label Jun 27, 2021
@tanhauhau tanhauhau force-pushed the fix-a11y-audio-media-element branch from c81244b to 253bd60 Compare July 11, 2022 01:57
@tanhauhau
Copy link
Member

Thanks for the change. I'm going to close this, since the a11y warning is removed now, check on the PR #6054 to learn why the a11y checking is removed.

@tanhauhau tanhauhau closed this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Changes relating to the compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants