Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use el.dataset.foo = bar instead of setAttribute(el, 'data-foo', bar) #858

Closed
Rich-Harris opened this issue Sep 17, 2017 · 0 comments
Closed

Use el.dataset.foo = bar instead of setAttribute(el, 'data-foo', bar) #858

Rich-Harris opened this issue Sep 17, 2017 · 0 comments

Comments

@Rich-Harris
Copy link
Member

REPL. dataset is supported in all current browsers — we should probably generate this code...

div.dataset.foo = "bar";

...instead of this...

setAttribute(div, "data-foo", "bar");

...unless the legacy option is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rich-Harris