Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use el.dataset.foo = bar instead of setAttribute(el, 'data-foo', bar) #929

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Use el.dataset.foo = bar instead of setAttribute(el, 'data-foo', bar) #929

merged 1 commit into from
Nov 18, 2017

Conversation

esarbanis
Copy link
Contributor

Closes #858

@Rich-Harris Rich-Harris merged commit 0774284 into sveltejs:master Nov 18, 2017
@Rich-Harris
Copy link
Member

thank you!

@esarbanis esarbanis deleted the do-use-dataset branch November 27, 2017 08:16
@adonespitogo
Copy link

This caused errors on old browsers. I need to support old android browsers (gingerbread) and it has no support for HTMLElement.dataset.

@Rich-Harris
Copy link
Member

@adonespitogo use the legacy: true compiler option

@adonespitogo
Copy link

@Rich-Harris thanks a lot!

sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
@github-actions @Rich-Harris
Sync kit docs (sveltejs#929)
fb84f19 
sync kit docs

Co-authored-by: Rich-Harris <1162160+Rich-Harris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esarbanis @Rich-Harris @adonespitogo