Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute casing better #1126

Merged
merged 2 commits into from
Jan 26, 2018
Merged

Fix attribute casing better #1126

merged 2 commits into from
Jan 26, 2018

Conversation

Conduitry
Copy link
Member

Properly handles when attributes aren't already lowercase.

For completeness, also normalizes attributes when they are being serialized as part of static HTML, although that isn't actually necessary, as the browser will correct the case anyway.

@Conduitry
Copy link
Member Author

I have no idea what these build failures are about. It looks like travis and appveyor are agreeing on them, and they're all related to transition tests.

@Conduitry
Copy link
Member Author

Conduitry commented Jan 25, 2018

These tests are failing because CI is using npm to install the dependencies instead of Yarn, and so is getting the latest versions of them, rather than the ones in the Yarn lockfile. It looks like the update from jsdom 11.5.1 to 11.6.0 is the culprit. I would guess this is related to "Added a window.performance implementation, including the basics of the High Resolution Time specification: performance.now(), performance.timeOrigin, and performance.toJSON()."

edit: Changing the window.performance test hack from window.performance = { now: () => raf.time }; to window.performance.now = () => raf.time; fixes all but one of the tests under the latest version of jsdom, so I'd say this is related.

@Conduitry
Copy link
Member Author

Test failure stuff separated into #1127 / #1128

@codecov-io
Copy link

codecov-io commented Jan 26, 2018

Codecov Report

Merging #1126 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         125      126    +1     
  Lines        4522     4522           
  Branches     1459     1459           
=======================================
  Hits         4137     4137           
  Misses        163      163           
  Partials      222      222
Impacted Files Coverage Δ
src/generators/nodes/Element.ts 94.42% <100%> (ø) ⬆️
src/utils/fixAttributeCasing.ts 100% <100%> (ø)
src/generators/nodes/Attribute.ts 85.49% <100%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a0765...c3bec8f. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 9f088fe into master Jan 26, 2018
@Rich-Harris Rich-Harris deleted the gh-1062-again branch January 26, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants