Croatian (hr): month names and weekday abbreviations #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use genitive case for formatting month names, such as: "13. kolovoza 2024." Use a period after abbreviation names, as is orthographically correct.
vipera
force-pushed
the
hr-month-abbreviation-improvements
branch
from
438b0c9
to
c9c65cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the Croatian date & time localization could do with more improvements to be orthographically correct:
I'm not entirely sure the first change results in the expected string when looking at the month names by themselves. However, the most common use of these localizations seems to be using the month name in a date string such as the example above, where it would be correct. Since they are already represented in lowercase, it seems that they are mostly intended to from a date format string and not be used individually.
Basically, it would be unexpected to use "kolovoza" by itself, as it means "of August". I'm wondering if you have any input on whether I'm correct in assuming this is the intended or most frequent use of these translated strings.