Conditionally enable TLS only on supported platforms #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is better to define a feature in minserve to access it more easily in source and also add the ability to disable rustls for supported platforms. [dependencies]
actix-web = "3"
rustls = { version = "0.18", optional = true }
[features]
tls = ["rustls", "actix-web/rustls"] |
|
Good idea, I switched it. |
svenstaro
force-pushed
the
conditional-tls
branch
2 times, most recently
from
8b896b1 to
2ea23ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use rustls only on architecturs supported by ring. See also briansmith/ring#1182 and briansmith/ring#562 and briansmith/ring#1367