fix: add configuration property that allows disabling setting of noti… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy-keyspace-events on redis server Before this fix, when starting encore, spring data redis would try to use the CONFIG command to set notify-keyspace-events on the redis server. If the server did not support the CONFIG command, which is the case in many managed redis services, encore would fail to start. With this fix, setting the property redis.keyspace.disable-config-notifications to true string will stop spring data redis from trying to change the config. If the property is not set, or set to true, spring data redis will behave as before, that is use the CONFIG command to set 'notify-keyspace-events'. Note that this fix does not seem to work when native compile is used. Signed-off-by: Gustav Grusell <gustav.grusell@eyevinn.se>
grusell
force-pushed
the
25-fails-to-start-with-managed-redis
branch
from
ad96c5f
to
e85ce9f
Compare
|
Any chance of getting this merged? |
|
It has been merged in our upstream repo and pushed to master here in GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #25 Encore fails to start if redis server is not configured to allow CONFIG command
Before this fix, when starting encore, spring data redis would try to use the CONFIG command to set notify-keyspace-events on the redis server. If the server did not support the CONFIG command, which is the case in many managed redis services, encore would fail to start.
With this fix, setting the property redis.keyspace.disable-config-notifications to true string will stop spring data redis from trying to change the config. If the property is not set, or set to false, spring data redis will behave as before, that is use the CONFIG command to set 'notify-keyspace-events'.
Note that this fix does not seem to solve the issue when native compile is used.