Skip to content

Conversation

@wing328
Copy link
Contributor

@wing328 wing328 commented Oct 18, 2016

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Improvements based on feedbacks in #3568

@wing328 wing328 added this to the v2.2.2 milestone Oct 18, 2016
@wing328 wing328 mentioned this pull request Oct 18, 2016
@wing328 wing328 merged commit 52ffc78 into swagger-api:master Oct 18, 2016
@wing328 wing328 deleted the java6support branch October 18, 2016 08:32
acramatte added a commit to comerge/swagger-codegen that referenced this pull request Oct 25, 2016
* upstream/master: (43 commits)
  [Java] BeanValidation + JAXRS CXF server generator (swagger-api#4068)
  update JS petstore samples
  nancyfx basePath => modulePath toggle (swagger-api#4053)
  Throw an Error object instead of a string
  [Qt5/C++] Arrays of primitive types fix (swagger-api#4046)
  fix NancyFX string parser (swagger-api#4048)
  Fix sanitizeTag to retain numbers and underscore in tag names
  add test for java6 jersey2 client
  hashCode and equals support for jdk6 for jersey2 (swagger-api#4039)
  update gitignore to include PetStore.pro.user
  increase timeout value for qt5 petstore test
  update undertow readme
  Java6 support for jersey2 (swagger-api#4033)
  [java] Allow setting test folder
  fix reserved word handling in model name (sinatra)
  better handling of reserved words for sintatra, dart
  improvements based on swagger-api#3568 (swagger-api#4021)
  [csharp] add missing anchor tags in readme (swagger-api#4019)
  Issue 3651 (swagger-api#4014)
  Added company (swagger-api#4015)
  ...
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant