[Java][Jersey2] add hashCode and equals support for JDK6 #4039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
I think this also fixes generated build artifacts to handle changes in #4033. Thanks scannerscan! |
Contributor
|
@k1w1m8 thanks for reviewing the change. @scannerscan thanks for the contribution. The change looks good to me. |
wing328
added
Enhancement: Feature
Enhancement: Compatibility
and removed
Enhancement: Feature
labels
Contributor
|
FYI. Filed #4041 to add CI tests for Java API client (jersey2, java6) |
acramatte
added a commit
to comerge/swagger-codegen
that referenced
this pull request
Oct 25, 2016
* upstream/master: (43 commits) [Java] BeanValidation + JAXRS CXF server generator (swagger-api#4068) update JS petstore samples nancyfx basePath => modulePath toggle (swagger-api#4053) Throw an Error object instead of a string [Qt5/C++] Arrays of primitive types fix (swagger-api#4046) fix NancyFX string parser (swagger-api#4048) Fix sanitizeTag to retain numbers and underscore in tag names add test for java6 jersey2 client hashCode and equals support for jdk6 for jersey2 (swagger-api#4039) update gitignore to include PetStore.pro.user increase timeout value for qt5 petstore test update undertow readme Java6 support for jersey2 (swagger-api#4033) [java] Allow setting test folder fix reserved word handling in model name (sinatra) better handling of reserved words for sintatra, dart improvements based on swagger-api#3568 (swagger-api#4021) [csharp] add missing anchor tags in readme (swagger-api#4019) Issue 3651 (swagger-api#4014) Added company (swagger-api#4015) ...
wing328
changed the title
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
We are working with jdk6 and jersey2 at the moment and cannot use jdk7 generated classes. I have reused 'supportJava6' flag as a switch to make some changes to the templates, so, apache commons libs can be used instead. I have changed pom, gradle and sbt as well.