Skip to content

Conversation

@ePaul
Copy link
Contributor

@ePaul ePaul commented Mar 2, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change.

Description of the PR

No functional changes at all, just updated the samples for all the languages mentioned in #4898.
This will later allow to see what happened when fixing the bug there.

@ePaul
Copy link
Contributor Author

ePaul commented Mar 2, 2017

#4874 did the same for just the spring samples.

@wing328
Copy link
Contributor

wing328 commented Mar 3, 2017

The CI (travis) issue will be resolved by #4904. I'll let you know once it's merged into master.

@wing328 wing328 added this to the v2.2.3 milestone Mar 3, 2017
@wing328
Copy link
Contributor

wing328 commented Mar 3, 2017

#4904 has been merged into master. Please rebase on the latest master to see if the CI (travis) issue goes away.

@ePaul ePaul force-pushed the update-samples-after-2.2.2 branch from 984a292 to 593806a Compare March 3, 2017 17:30
@ePaul
Copy link
Contributor Author

ePaul commented Mar 3, 2017

Rebased.

@ePaul
Copy link
Contributor Author

ePaul commented Mar 3, 2017

@wing328 now it complains about dependencies for Scalatra:

https://travis-ci.org/swagger-api/swagger-codegen/jobs/207441746

[info] Set current project to scalatra-sample (in build file:/home/travis/build/swagger-api/swagger-codegen/samples/server/petstore/scalatra/)
[info] Updating {file:/home/travis/build/swagger-api/swagger-codegen/samples/server/petstore/scalatra/}scalatra...
java.lang.IllegalArgumentException: Cannot add dependency 'com.github.finagle#finch-test_2.11;0.9.2-SNAPSHOT' to configuration 'it' of module io.swagger#scalatra-sample_2.11;0.1.0-SNAPSHOT because this configuration doesn't exist!
	at org.apache.ivy.core.module.descriptor.DefaultDependencyDescriptor.addDependencyConfiguration(DefaultDependencyDescriptor.java:559)
	at org.apache.ivy.plugins.parser.AbstractModuleDescriptorParser$AbstractParser.parseDepsConfs(AbstractModuleDescriptorParser.java:157)
	at org.apache.ivy.plugins.parser.AbstractModuleDescriptorParser$AbstractParser.parseDepsConfs(AbstractModuleDescriptorParser.java:128)
	at org.apache.ivy.plugins.parser.AbstractModuleDescriptorParser$AbstractParser.parseDepsConfs(AbstractModuleDescriptorParser.java:118)
	at org.apache.ivy.plugins.parser.AbstractModuleDescriptorParser$AbstractParser.parseDepsConfs(AbstractModuleDescriptorParser.java:113)
	at sbt.CustomXmlParser$CustomParser.parseDepsConfs(CustomXmlParser.scala:35)
	at sbt.IvySbt$.convertDependency(Ivy.scala:561)
	at sbt.IvySbt$$anonfun$5.apply(Ivy.scala:511)
	at sbt.IvySbt$$anonfun$5.apply(Ivy.scala:511)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.immutable.List.foreach(List.scala:318)
	at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
	at scala.collection.AbstractTraversable.map(Traversable.scala:105)
	at sbt.IvySbt$.addDependencies(Ivy.scala:511)
	at sbt.IvySbt$Module.configureInline(Ivy.scala:152)
	at sbt.IvySbt$Module.x$6$lzycompute(Ivy.scala:131)
	at sbt.IvySbt$Module.x$6(Ivy.scala:126)
	at sbt.IvySbt$Module.sbt$IvySbt$Module$$moduleDescriptor0$lzycompute(Ivy.scala:126)
	at sbt.IvySbt$Module.sbt$IvySbt$Module$$moduleDescriptor0(Ivy.scala:126)
	at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:115)
	at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:115)
	at sbt.IvySbt$$anonfun$withIvy$1.apply(Ivy.scala:103)
	at sbt.IvySbt.sbt$IvySbt$$action$1(Ivy.scala:48)
	at sbt.IvySbt$$anon$3.call(Ivy.scala:57)
	at xsbt.boot.Locks$GlobalLock.withChannel$1(Locks.scala:98)
	at xsbt.boot.Locks$GlobalLock.xsbt$boot$Locks$GlobalLock$$withChannelRetries$1(Locks.scala:81)
	at xsbt.boot.Locks$GlobalLock$$anonfun$withFileLock$1.apply(Locks.scala:102)
	at xsbt.boot.Using$.withResource(Using.scala:11)
	at xsbt.boot.Using$.apply(Using.scala:10)
	at xsbt.boot.Locks$GlobalLock.ignoringDeadlockAvoided(Locks.scala:62)
	at xsbt.boot.Locks$GlobalLock.withLock(Locks.scala:52)
	at xsbt.boot.Locks$.apply0(Locks.scala:31)
	at xsbt.boot.Locks$.apply(Locks.scala:28)
	at sbt.IvySbt.withDefaultLogger(Ivy.scala:57)
	at sbt.IvySbt.withIvy(Ivy.scala:98)
	at sbt.IvySbt.withIvy(Ivy.scala:94)
	at sbt.IvySbt$Module.withModule(Ivy.scala:115)
	at sbt.IvyActions$.update(IvyActions.scala:125)
	at sbt.Classpaths$$anonfun$sbt$Classpaths$$work$1$1.apply(Defaults.scala:1223)
	at sbt.Classpaths$$anonfun$sbt$Classpaths$$work$1$1.apply(Defaults.scala:1221)
	at sbt.Classpaths$$anonfun$doWork$1$1$$anonfun$74.apply(Defaults.scala:1244)
	at sbt.Classpaths$$anonfun$doWork$1$1$$anonfun$74.apply(Defaults.scala:1242)
	at sbt.Tracked$$anonfun$lastOutput$1.apply(Tracked.scala:35)
	at sbt.Classpaths$$anonfun$doWork$1$1.apply(Defaults.scala:1246)
	at sbt.Classpaths$$anonfun$doWork$1$1.apply(Defaults.scala:1241)
	at sbt.Tracked$$anonfun$inputChanged$1.apply(Tracked.scala:45)
	at sbt.Classpaths$.cachedUpdate(Defaults.scala:1249)
	at sbt.Classpaths$$anonfun$updateTask$1.apply(Defaults.scala:1214)
	at sbt.Classpaths$$anonfun$updateTask$1.apply(Defaults.scala:1192)
	at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
	at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:42)
	at sbt.std.Transform$$anon$4.work(System.scala:64)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:237)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:237)
	at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:18)
	at sbt.Execute.work(Execute.scala:244)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:237)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:237)
	at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:160)
	at sbt.CompletionService$$anon$2.call(CompletionService.scala:30)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)
[error] (*:update) java.lang.IllegalArgumentException: Cannot add dependency 'com.github.finagle#finch-test_2.11;0.9.2-SNAPSHOT' to configuration 'it' of module io.swagger#scalatra-sample_2.11;0.1.0-SNAPSHOT because this configuration doesn't exist!
Project loading failed: (r)etry, (q)uit, (l)ast, or (i)gnore? 

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

@ePaul
Copy link
Contributor Author

ePaul commented Mar 3, 2017

Ah, I didn't actually regenerate the samples after rebasing. Trying it now for scalatra.

@ePaul
Copy link
Contributor Author

ePaul commented Mar 3, 2017

Hmm, executing either bin/jaxrs-jersey1-petstore-server.sh or bin/scalatra-petstore-server.sh produces no change.

@ePaul
Copy link
Contributor Author

ePaul commented Mar 4, 2017

I'll try to split this up into several PRs to isolate the problem.

@ePaul ePaul force-pushed the update-samples-after-2.2.2 branch from 593806a to 73ace30 Compare March 4, 2017 10:04
@ePaul
Copy link
Contributor Author

ePaul commented Mar 4, 2017

After showing in #4910 that the Scalatra samples are the reason for the problem, I'm rebasing this to omit the scalatra changes (as well as swift3, which is in a separate PR #4911). Let's see what CI says now.

@ePaul
Copy link
Contributor Author

ePaul commented Mar 4, 2017

Build passed now.

@wing328
Copy link
Contributor

wing328 commented Mar 5, 2017

@ePaul thanks for the PR to update the samples.

@wing328 wing328 merged commit a91cbbe into swagger-api:master Mar 5, 2017
@ePaul ePaul deleted the update-samples-after-2.2.2 branch March 5, 2017 19:24
spr3nk3ls pushed a commit to spr3nk3ls/swagger-codegen that referenced this pull request Mar 28, 2017
* Update petstore samples for Groovy.

* Update samples for JaxRS.

* Update samples for cpprest.

* Update samples for dart.

* Update samples for flash.

* Update samples for go.

* Update samples for html2.

* Update samples for lumen.

* Update samples for nancxfx.

* Update samples for objc.

* Update samples for sinatra.

* Update samples for tizen.

* Update samples for java-inflector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants