-
Notifications
You must be signed in to change notification settings - Fork 6k
Update samples for Scalatra after 2.2.2. #4910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmm, same error as mentioned in #4901 (comment). |
|
It looks like this got broken with #3905 ... which forgot to update the samples, and is marked as "WIP". |
Changes were made in conjunction with the new finch generator. This reverts those changes to Scalatra's previous build.sbt.
|
@ePaul I opened ePaul#1 to revert the changes made to the Scalatra generator, which was changed by accident. #3905 shouldn't have affected other generators at all. I rebuilt the Scalatra server sample locally and verified it worked after the changes. I didn't push that to the linked PR because I figured you'd want to re-run it and verify anyway. |
[scalatra] Revert changes to build.sbt
|
@jimschubert Thanks, merged this and updated the samples again. Let's see what Travis will tell us. (It didn't affect other generators, but something based on the Scalatra generator was included in the Travis CI build.) |
23136e7 to
9fc630e
Compare
|
Worked (on the second try, some NPM stuff seems to be nondeterministically failing). Thanks. |
|
No problem. I've seen npm randomly failing on the build quite a bit. I haven't looked into it, unfortunately. I wonder if could use yarn instead. |
Sure. Feel free to give that a try to see if it works better. |
* Update samples for Scalatra after 2.2.2. * [scalatra] Revert changes to build.sbt Changes were made in conjunction with the new finch generator. This reverts those changes to Scalatra's previous build.sbt. * Update scalatra samples again after revert of part of swagger-api#3905.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ just bin/scalatra-petstore.sh
2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
This just updates the scalatra samples without any functionality changes.
(This is a part of #4901 split out into a separate PR to see if CI likes it better than the whole thing.)