[Erlang] pretty print swagger json #5215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2017 22:57
(This was done via `jq`. In a later commit we'll generate it pretty-printed.)
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
* Pretty-print swagger.json. (This was done via `jq`. In a later commit we'll generate it pretty-printed.) * Erlang Server: pretty-print generated swagger.json. * Update samples for Erlang-server.
russtacular
added a commit
to russtacular/swagger-codegen
that referenced
this pull request
Mar 28, 2017
…ile-upload-and-dependency-updates * swagger/master: (59 commits) [Java][Retrofit2] update gradle, sbt build file with latest dependencies (swagger-api#5238) update retrofit2 dependencies (swagger-api#5235) Issue swagger-api#3084: remove timestamps from undertow samples (swagger-api#5231) add port 80 to swagger spec (swagger-api#5232) fix msf4j bin script fix c# docstring typo (swagger-api#5223) add comments to csharp methods (swagger-api#5222) fix retrofit2 indentation (swagger-api#5221) Updating samples for spring-stubs, springboot-delegate, springboot-delegate-j8. (swagger-api#5211) export top level enumeration types in typescript-fetch mode (swagger-api#4820) [Erlang] pretty print swagger json (swagger-api#5215) add ci test for msf4j server (swagger-api#5220) Updating samples for JaxRS servers: Spec + CXF-CDI. (swagger-api#5213) Update samples for JaxRS/RestEasy/Joda. (swagger-api#5205) Update samples for Undertow. (swagger-api#5207) Update samples for okhttp-gson-parcelableModel. (swagger-api#5208) Update samples for Java Inflector. (swagger-api#5204) [java][msf4j] Update msf4j samples (and fix artifact name) (swagger-api#5210) Update samples for Ruby-Client + Rails server. (swagger-api#5214) [ASP.NET] Issue swagger-api#5196: add packageGuid parameter to AspNetCoreServerCodegen. (swagger-api#5199) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ bin/erlang-petstore-server.sh
Description of the PR
I wanted to just update the samples, but noticed there that the generated swagger.json is a single line (of 13593 bytes before the update vs. 14000 bytes afterwards).
There is no way of reviewing the changes therein.
So this PR adds pretty-printing of the swagger.json to the generation process, then updates the samples.
In a first commit I manually pretty-printed the swagger.json, using
jq– this is not exactly the same format, but with ignoring whitespace changes you can see the actual changes in the later commits. As far as I can see, only added title/description for some of the models, and a"minimum": 1removed for the orderId parameter.Other than this, swagger_api.erl has some minor changes (the same
{min,1.0}removed, and at one point changed numbers with.0to ones without.)