Skip to content

Conversation

@wing328
Copy link
Contributor

@wing328 wing328 commented Mar 27, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

For #5219. Also fixed indentation in pom.xml

@wing328 wing328 added this to the v2.2.3 milestone Mar 27, 2017
@wing328 wing328 merged commit 1a1f5af into swagger-api:master Mar 27, 2017
@ePaul
Copy link
Contributor

ePaul commented Mar 27, 2017

Could you try to update the MSF4J samples again? When I try it, it seems like your changes here are overwritten again (which defeats the purpose of the test).

<modelVersion>4.0.0</modelVersion>
<groupId>io.swagger</groupId>
<artifactId>swagger-msf4j-server</artifactId>
<artifactId>swagger-jaxrs-server</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Let me fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via 05c671a

@wing328 wing328 deleted the update_ci branch March 28, 2017 01:54
spr3nk3ls pushed a commit to spr3nk3ls/swagger-codegen that referenced this pull request Mar 28, 2017
russtacular added a commit to russtacular/swagger-codegen that referenced this pull request Mar 28, 2017
…ile-upload-and-dependency-updates

* swagger/master: (59 commits)
  [Java][Retrofit2] update gradle, sbt build file with latest dependencies (swagger-api#5238)
  update retrofit2 dependencies (swagger-api#5235)
  Issue swagger-api#3084: remove timestamps from undertow samples (swagger-api#5231)
  add port 80 to swagger spec (swagger-api#5232)
  fix msf4j bin script
  fix c# docstring typo (swagger-api#5223)
  add comments to csharp methods (swagger-api#5222)
  fix retrofit2 indentation (swagger-api#5221)
  Updating samples for spring-stubs, springboot-delegate, springboot-delegate-j8. (swagger-api#5211)
  export top level enumeration types in typescript-fetch mode (swagger-api#4820)
  [Erlang] pretty print swagger json (swagger-api#5215)
  add ci test for msf4j server (swagger-api#5220)
  Updating samples for JaxRS servers: Spec + CXF-CDI. (swagger-api#5213)
  Update samples for JaxRS/RestEasy/Joda. (swagger-api#5205)
  Update samples for Undertow. (swagger-api#5207)
  Update samples for okhttp-gson-parcelableModel. (swagger-api#5208)
  Update samples for Java Inflector. (swagger-api#5204)
  [java][msf4j] Update msf4j samples (and fix artifact name) (swagger-api#5210)
  Update samples for Ruby-Client + Rails server. (swagger-api#5214)
  [ASP.NET] Issue swagger-api#5196: add packageGuid parameter to AspNetCoreServerCodegen. (swagger-api#5199)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants