[JaxRS Server][Jersey1/2] Pass server port by cli #5246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ePaul thanks for the enhancement, which makes it much easier to set the server port. |
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
* JaxRS server: set serverPort only when not given from outside. * Update JaxRS sample creator scripts to fix serverPort. * Preliminary test fix for JaxRS server generators. * Updating samples for JaxRS with Jersey1/2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ bin/jaxrs-jersey1-petstore-server.sh, bin/jaxrs-petstore-server.sh
Description of the PR
We are introducing a CLI argument
serverPortto the generators which overrides the port given in the API definition'shostor the default of8080.This we use from the generating scripts, so the CI tests won't try to use
80(which is usually reserved to privileged processes).(Triggered by the change in #5232 and the failing tests in #5243.)