Updating samples after #5232. #5243
Conversation
|
@wing328 some tests now fail, at least one of the tests for feign. I'll have a look at this later, if you don't want to fix this first. |
|
I'm on it for the Java-based tests (because I can easily run them locally). Will push the result then for CI. |
|
These now try to start a server at port 80 (and have no permissions to do so on my computer):
|
| <stopWait>10</stopWait> | ||
| <httpConnector> | ||
| <port>8080</port> | ||
| <port>80</port> |
There was a problem hiding this comment.
This change makes the server try to start at port 80, which (at least on normal Linux systems) is not permitted for non-privileged processes.
Same for the jersey2 variant of this.
|
I merged the branch of #5246 into this one, so that should be merged first, if it is deemed a plausible solution. (I can rebase this one afterwards, or revert the changes if not deemed okay.) |
|
@ePaul thanks for fixing all those test cases. |
* Updating samples after swagger-api#5232. * Fix tests after swagger-api#5232. * Fix Javascript client tests. * JaxRS server: set serverPort only when not given from outside. * Update JaxRS sample creator scripts to fix serverPort. * Preliminary test fix for JaxRS server generators. * Updating samples for JaxRS with Jersey1/2. * Updating JaxRS samples again.
2 participants
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.I ran bin/run-all-petstore, but before committing I omitted some changes listed below.
Description of the PR
No code changes, just updating the samples.
All the changes here come from #5232, which forgot to update the samples.
I omitted the changes covered by #5242, #5241, #5212, as well as changes in typescript-angular2/npm and typescript-jquery/npm, which have the date in their artifact ID (see #3084).
Interesting in the diff might be the several cases which replaced 8080 → 80.