Fixes in escaping when generating Java from swagger.json (2) #5247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
@ePaul yup, we can add examples to the fake petstore spec so as to cover these cases |
Contributor
|
@spr3nk3ls thanks for the PR, which has been merged into master. I'll create an issue to track updating fake petstore with examples you provided in your spec. |
kenjones-cisco
added a commit
to kenjones-cisco/swagger-codegen
that referenced
this pull request
May 2, 2017
Applies the same fix as swagger-api#5247 to avoid invalid escaping of the attribute example within `ApiModelProperty`. Resolves swagger-api#5534
3 tasks
wing328
pushed a commit
that referenced
this pull request
May 3, 2017
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
Applies the same fix as swagger-api#5247 to avoid invalid escaping of the attribute example within `ApiModelProperty`. Resolves swagger-api#5534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some valid json expressions within a swagger.json file result in uncompilable Java code.
How to test:
Use this pom.xml and this swagger.json to generate an example swagger API client in Java.
Expected: the code generated results in compilable Java.
Result: the resulting Java does not compile, because expressions like
"example": "[\"RABO23124NL\",\"RABO12345NL\"]",and"example": "\\\"[A-Z.]{1,10}\\",are escaped incorrectly.I was unable to fix my original PR (#5234), so I created this one instead. Suggestions made on the original PR have been processed in this one.