Skip to content

Conversation

@kenjones-cisco
Copy link
Contributor

@kenjones-cisco kenjones-cisco commented May 2, 2017

Applies the same fix as #5247 to avoid invalid escaping of the attribute
example within ApiModelProperty.

Resolves #5534

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Resolves issue described within #5534 for JavaSpring

Applies the same fix as swagger-api#5247 to avoid invalid escaping of the attribute
example within `ApiModelProperty`.

Resolves swagger-api#5534
@wing328
Copy link
Contributor

wing328 commented May 2, 2017

@kenjones-cisco thanks for the fix.

I'll do a grep tomorrow to look for {{example}} in other templates and replace it with {{{example}}} instead.

@wing328 wing328 added this to the v2.2.3 milestone May 2, 2017
@wing328 wing328 merged commit 06f8ac4 into swagger-api:master May 3, 2017
@wing328
Copy link
Contributor

wing328 commented May 3, 2017

Clean up of {{example}} done via #5540

@wing328 wing328 changed the title Bugfix: JavaSpring pojo example escape [Java][Spring] fix incorrect escape of POJO's example May 3, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Applies the same fix as swagger-api#5247 to avoid invalid escaping of the attribute
example within `ApiModelProperty`.

Resolves swagger-api#5534
@kenjones-cisco kenjones-cisco deleted the bugfix/bean-example-escape branch May 15, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java Spring] escaping of example for bean properties

2 participants