[angular-typescript] imports HttpClientModule #6729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpModule has no effect, since the new `HttpClient` is now used. fixes #6727
macjohnny
suggested changes
Oct 19, 2017
| import { NgModule, ModuleWithProviders } from '@angular/core'; | ||
| import { CommonModule } from '@angular/common'; | ||
| import { HttpModule } from '@angular/http'; | ||
| import { HttpClientModule } from '@angular/common/http'; |
Contributor
There was a problem hiding this comment.
it should be distinguished between http client module and http module. See e.g. https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/typescript-angular/encoder.mustache#L1
moreover, the samples should be re-generated
4 tasks
Contributor
|
@JohannesHoppe could you close your PR in favor of #6757 ? |
Contributor
Author
|
@macjohnny sure 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpModule has no effect, since the new
HttpClientis now used. fixes #6727PR checklist
Done via the web-interface. I guarantee nothing. I'm not disappointed if you are not going merge it, but I'm pretty sure it works since the change trivial.