[TypeScript][Angular] fix issue with importing http client module #6757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpModule has no effect, since the new `HttpClient` is now used. fixes #6727
Contributor
Author
pgrm
approved these changes
Oct 19, 2017
Contributor
pgrm
left a comment
pgrm
left a comment
There was a problem hiding this comment.
oh yeah cool, that's also a local fix I had laying around 👍
Contributor
|
@wing328 you can mark this one also with bug and typescript |
Contributor
Author
|
@wing328 @sebastianhaas the checks passed, how about merging? |
sebastianhaas
approved these changes
Oct 23, 2017
|
|
||
| message?: string; | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
Still wondering about those newlines
Contributor
There was a problem hiding this comment.
I can try to clean it up later with a separate PR.
4 tasks
Contributor
Author
|
@wing328 can you restart the circleci test? |
Contributor
Author
|
@wing328 the checks passed, could you please merge this? |
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
fixes #6727 and replaces PR #6729