feat: support replace FieldParser #1043
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1043 +/- ##
==========================================
+ Coverage 92.96% 93.05% +0.09%
==========================================
Files 7 8 +1
Lines 2018 2046 +28
==========================================
+ Hits 1876 1904 +28
Misses 79 79
Partials 63 63
Continue to review full report at Codecov.
|
|
@forsaken628 Looks good until now, congrats. We will need to have positive coverage on parser.go so we can merge it. |
|
I move a lot code to new file. So it's seem no possible have positive coverage on parser.go. |
|
@forsaken628 The code in parser.go conflicts with my modifications, #1045 😄 |
| @@ -1053,13 +1057,25 @@ func (parser *Parser) parseStructField(file *ast.File, field *ast.Field) (map[st | |||
| return map[string]spec.Schema{typeName: *schema}, nil, nil | |||
| } | |||
|
|
|||
| fieldName, schema, err := parser.getFieldName(field) | |||
| ps := newTagBaseFieldParser(parser, field) | |||
There was a problem hiding this comment.
@forsaken628 It should be:
ps := parser.fieldParserFactory(parser, field)
Describe the PR
Support replace FieldParser. Then we can use this as a libary and write custom feature.
Relation issue
no
Additional context
no