-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support go-playground/validator tags. #1045
Conversation
@HYY-yu Some conflicts need to be fixed before we can go forward. |
parser_test.go
Outdated
}, field) | ||
|
||
}) | ||
t.Run("Required with oneof tag", func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/go-playground/validator/blob/d4271985b44b735c6f76abc7a06532ee997f9476/baked_in.go#L207
https://github.com/go-playground/validator/blob/f6584a41c8acc5dfc0b62f7962811f5231c11530/cache.go#L297
https://github.com/go-playground/validator/blob/d4271985b44b735c6f76abc7a06532ee997f9476/validator_test.go#L5073
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review again.
fix this? I'm just a another contributor. |
@forsaken628 No, should I fix it on this PR ? |
of course,this is a bug! |
@forsaken628 Ok, fixed by |
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
+ Coverage 93.05% 93.34% +0.28%
==========================================
Files 8 8
Lines 2046 2134 +88
==========================================
+ Hits 1904 1992 +88
Misses 79 79
Partials 63 63
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@HYY-yu Thanks for your contribution. |
Describe the PR
Support
go-playground/validator
.Support for parsing more tags of validator, such as max\min\oneof.
example:
after:
Relation issue
#995