support custom attributes defined in scenarios #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
force-pushed
the
custom-attrs
branch
2 times, most recently
from
259c91a to
1bcac2a
Compare
xsebek
approved these changes
Jan 28, 2023
src/Swarm/Game/Scenario/Style.hs
Outdated
| where | ||
| addFg = maybe id (flip withForeColor . toAttrColor) $ fg ca | ||
| addBg = maybe id (flip withBackColor . toAttrColor) $ bg ca | ||
| addStyle = maybe id (flip withStyle . sum . map toStyle . toList) $ style ca |
byorgey
approved these changes
Jan 28, 2023
src/Swarm/Game/Scenario/Style.hs
Outdated
| import GHC.Generics (Generic) | ||
| import Graphics.Vty.Attributes | ||
| import Numeric (readHex) | ||
| import Swarm.TUI.Attr (worldPrefix) |
There was a problem hiding this comment.
I agree with @xsebek , I think it would be better to do this in a way that didn't depend on anything in Swarm.TUI.*, partly just out of a sense that conceptually the abstract game should not depend on the specifics of the user interface, and partly for the practical reason that we might want to have different interfaces in the future.
This was referenced Feb 27, 2023
Merged
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
Previously, custom attributes with only a foreground or only a background set would inherit the foreground/background to the left of them. This is due to mistakenly using `currentAttr` instead of `defAttr` in #1058. | Version | Screenshot | | --- | --- | | Before |  | | Fixed |  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1034
Demo