Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump containers version #2165

Merged
merged 2 commits into from
Oct 24, 2024
Merged

bump containers version #2165

merged 2 commits into from
Oct 24, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Oct 11, 2024 •
edited
Loading

@kostmo kostmo force-pushed the kostmo/containers-bump branch from bb501e9 to 339bfca Compare October 15, 2024 16:02
@kostmo kostmo changed the title bump containers version bump containers version, use NECyclicSCC constructor Oct 15, 2024
@kostmo kostmo force-pushed the kostmo/containers-bump branch from 339bfca to ecf91ba Compare October 15, 2024 16:04
@kostmo kostmo added Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. merge me Trigger the merge process of the Pull request. labels Oct 15, 2024
@kostmo kostmo marked this pull request as ready for review October 15, 2024 16:04
@byorgey
Copy link
Member

byorgey commented Oct 15, 2024

Yeah, using NECyclicSCC and requiring containers >= 0.7 is probably not going to work, for now. There are still too many pieces of the ecosystem that require an older version.

@kostmo kostmo removed the merge me Trigger the merge process of the Pull request. label Oct 21, 2024
@kostmo kostmo force-pushed the kostmo/containers-bump branch from ecf91ba to 860dd92 Compare October 21, 2024 00:59
@kostmo kostmo changed the title bump containers version, use NECyclicSCC constructor bump containers version Oct 24, 2024
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Oct 24, 2024
@mergify mergify bot merged commit adb7d70 into main Oct 24, 2024
10 checks passed
@mergify mergify bot deleted the kostmo/containers-bump branch October 24, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey