Skip to content

Commit

Permalink
refactor(css/ast): Remove UniversalSelector (#2673)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-akait authored Nov 8, 2021
1 parent 98fc409 commit 4484d64
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
6 changes: 0 additions & 6 deletions css/ast/src/selector.rs
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,6 @@ pub struct PseudoSelector {
pub args: Tokens,
}

/// `*`
#[ast_node]
pub struct UniversalSelector {
pub span: Span,
}

#[ast_node("IdSelector")]
pub struct IdSelector {
pub span: Span,
Expand Down
1 change: 0 additions & 1 deletion css/parser/tests/fixture.rs
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ impl Visit for SpanVisualizer<'_> {
mtd!(Tokens, visit_tokens);
mtd!(Unit, visit_unit);
mtd!(UnitValue, visit_unit_value);
mtd!(UniversalSelector, visit_universal_selector);
mtd!(UrlValue, visit_url_value);
mtd!(Value, visit_value);

Expand Down
4 changes: 0 additions & 4 deletions css/visit/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,6 @@ define!({
pub args: Tokens,
}

pub struct UniversalSelector {
pub span: Span,
}

pub struct IdSelector {
pub span: Span,
pub text: Text,
Expand Down

1 comment on commit 4484d64

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 4484d64 Previous: 98fc409 Ratio
base_tr_fixer 29271 ns/iter (± 4028) 23928 ns/iter (± 459) 1.22
base_tr_resolver_and_hygiene 154409 ns/iter (± 30500) 128664 ns/iter (± 28025) 1.20
codegen_es2015 53963 ns/iter (± 14999) 51337 ns/iter (± 281) 1.05
codegen_es2016 54782 ns/iter (± 10183) 51342 ns/iter (± 308) 1.07
codegen_es2017 53393 ns/iter (± 9390) 51065 ns/iter (± 309) 1.05
codegen_es2018 54860 ns/iter (± 16540) 51088 ns/iter (± 287) 1.07
codegen_es2019 53093 ns/iter (± 10892) 51167 ns/iter (± 559) 1.04
codegen_es2020 55628 ns/iter (± 7032) 51180 ns/iter (± 311) 1.09
codegen_es3 58395 ns/iter (± 5450) 51329 ns/iter (± 301) 1.14
codegen_es5 59272 ns/iter (± 5373) 51350 ns/iter (± 257) 1.15
full_es2015 207595902 ns/iter (± 22616165) 183224301 ns/iter (± 7624456) 1.13
full_es2016 155838700 ns/iter (± 14443673) 143166910 ns/iter (± 5021430) 1.09
full_es2017 170258681 ns/iter (± 16380106) 149875348 ns/iter (± 7298131) 1.14
full_es2018 166914232 ns/iter (± 12585658) 148933778 ns/iter (± 6031954) 1.12
full_es2019 164180275 ns/iter (± 25731919) 148087974 ns/iter (± 8738831) 1.11
full_es2020 161908987 ns/iter (± 15046282) 146960814 ns/iter (± 6229023) 1.10
full_es3 242350883 ns/iter (± 43614465) 213169885 ns/iter (± 18847487) 1.14
full_es5 224671572 ns/iter (± 24339384) 198661348 ns/iter (± 10832335) 1.13
parser 755563 ns/iter (± 95523) 637613 ns/iter (± 28399) 1.18
ser_ast_node 159 ns/iter (± 28) 147 ns/iter (± 3) 1.08
ser_serde 173 ns/iter (± 16) 157 ns/iter (± 3) 1.10
emit_colors 13366474 ns/iter (± 19864575) 17808725 ns/iter (± 23928615) 0.75
emit_large 86100690 ns/iter (± 135394534) 93296163 ns/iter (± 147344204) 0.92
base_clone 2655772 ns/iter (± 621611) 2293947 ns/iter (± 94085) 1.16
fold_span 4550528 ns/iter (± 787447) 3833396 ns/iter (± 146791) 1.19
fold_span_panic 4558468 ns/iter (± 514982) 4054529 ns/iter (± 385431) 1.12
visit_mut_span 3154745 ns/iter (± 701484) 2810404 ns/iter (± 129970) 1.12
visit_mut_span_panic 3081660 ns/iter (± 606134) 2885250 ns/iter (± 186260) 1.07
boxing_boxed 179 ns/iter (± 24) 145 ns/iter (± 2) 1.23
boxing_boxed_clone 79 ns/iter (± 21) 67 ns/iter (± 0) 1.18
boxing_unboxed 152 ns/iter (± 13) 129 ns/iter (± 0) 1.18
boxing_unboxed_clone 74 ns/iter (± 34) 63 ns/iter (± 0) 1.17

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.