Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(css/ast): remove UniversalSelector #2673

Merged
merged 2 commits into from
Nov 8, 2021
Merged

refactor(css/ast): remove UniversalSelector #2673

merged 2 commits into from
Nov 8, 2021

Conversation

alexander-akait
Copy link
Contributor

@alexander-akait alexander-akait commented Nov 7, 2021

Remove UniversalSelector, we don't use it in code (maybe we forgot to remove it when we do refactor), also UniversalSelector is subtype of TypeSelector.

@alexander-akait
Copy link
Contributor Author

alexander-akait commented Nov 7, 2021

Or we can bring it back because we have https://www.w3.org/TR/selectors-4/#the-universal-selector and fix the logic of code, I don't have strong option, maybe it will be useful for transformation or minification

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 enabled auto-merge (squash) November 8, 2021 04:07
@kdy1 kdy1 added this to the v1.2.108 milestone Nov 8, 2021
@kdy1 kdy1 merged commit 4484d64 into swc-project:master Nov 8, 2021
@alexander-akait alexander-akait deleted the refactor-code branch November 8, 2021 09:43
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants