fix(bundler): Fix bugs (#1346)

swc_bundler:
 - Fix keywords pass.

swc_ecma_transforms_optimization:
 - Remove `dbg!`.
 - `constant_propagation`: Inline only injected variables.

.github/workflows/cargo.yml

@@ -14,8 +14,6 @@ on: [push, pull_request]
 
 env:
   CARGO_INCREMENTAL: 0
-  # To make spack tests reliable
-  RAYON_NUM_THREADS: 1
   CI: "1"
 
 jobs:
@@ -29,9 +27,59 @@ jobs:
       - name: Run cargo fmt
         run: cargo fmt --all -- --check
 
+  check-all:
+    name: Compilability
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      # Ensure that all components all compilable.
+      - name: Run cargo check for all targets
+        run: cargo check --color always --all --all-targets
+
   test:
     name: test
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        crate:
+          - ast_node
+          - enum_kind
+          - from_variant
+          - jsdoc
+          - spack
+          - string_enum
+          - swc
+          - swc_atoms
+          - swc_bundler
+          - swc_common
+          - swc_ecma_ast
+          - swc_ecma_codegen
+          - swc_ecma_codegen_macros
+          - swc_ecma_dep_graph
+          - swc_ecma_ext_transforms
+          - swc_ecma_parser
+          - swc_ecma_preset_env
+          - swc_ecma_transforms
+          - swc_ecma_transforms_base
+          - swc_ecma_transforms_compat
+          - swc_ecma_transforms_macros
+          - swc_ecma_transforms_module
+          - swc_ecma_transforms_optimization
+          - swc_ecma_transforms_proposal
+          - swc_ecma_transforms_react
+          - swc_ecma_transforms_testing
+          - swc_ecma_transforms_typescript
+          - swc_ecma_utils
+          - swc_ecma_visit
+          - swc_ecmascript
+          - swc_eq_ignore_macros
+          - swc_macros_common
+          - swc_visit
+          - swc_visit_macros
+          - testing
+          - testing_macros
+
     steps:
       - uses: actions/checkout@v2
 
@@ -60,14 +108,10 @@ jobs:
             **/target/
           key: ${{ runner.os }}-cargo-test
 
-      # Ensure that all components all compilable.
-      - name: Run cargo check for all targets
-        run: cargo check --color always --all --all-targets
-
       - name: Run cargo test
         run: |
           export PATH="$PATH:$HOME/npm/bin"
-          cargo test --color always --all --exclude node --exclude wasm
+          cargo test --color always -p ${{ matrix.crate }}
   #
   deploy-docs:
     runs-on: ubuntu-latest

bundler/src/bundler/chunk/merge.rs

@@ -95,6 +95,12 @@ where
                 // );
             }
 
+            // print_hygiene(
+            //     &format!("processed: {}", info.fm.name),
+            //     &self.cm,
+            //     &module.clone().into(),
+            // );
+
             if is_entry {
                 self.replace_import_specifiers(&info, &mut module);
                 self.finalize_merging_of_entry(ctx, &mut module);
@@ -1043,6 +1049,12 @@ where
 
             new
         });
+
+        // print_hygiene(
+        //     &format!("prepared: {}", info.fm.name),
+        //     &self.cm,
+        //     &module.clone().into(),
+        // );
     }
 
     pub(super) fn replace_import_specifiers(&self, info: &TransformedModule, module: &mut Modules) {

bundler/src/bundler/keywords.rs

@@ -1,4 +1,5 @@
 use crate::id::Id;
+use crate::util::MapWithMut;
 use std::collections::HashMap;
 use swc_atoms::js_word;
 use swc_ecma_ast::*;
@@ -65,11 +66,35 @@ impl VisitMut for KeywordRenamer {
         }
     }
 
-    fn visit_mut_assign_pat_prop(&mut self, n: &mut AssignPatProp) {
-        if let Some(renamed) = self.renamed(&n.key) {
-            n.key = renamed;
+    fn visit_mut_object_pat_prop(&mut self, n: &mut ObjectPatProp) {
+        n.visit_mut_children_with(self);
+
+        match n {
+            ObjectPatProp::Assign(pat) => {
+                if let Some(renamed) = self.renamed(&pat.key) {
+                    match &mut pat.value {
+                        Some(default) => {
+                            *n = ObjectPatProp::KeyValue(KeyValuePatProp {
+                                key: PropName::Ident(pat.key.take()),
+                                value: Box::new(Pat::Assign(AssignPat {
+                                    span: pat.span,
+                                    left: Box::new(Pat::Ident(renamed)),
+                                    right: default.take(),
+                                    type_ann: None,
+                                })),
+                            });
+                        }
+                        None => {
+                            *n = ObjectPatProp::KeyValue(KeyValuePatProp {
+                                key: PropName::Ident(pat.key.take()),
+                                value: Box::new(Pat::Ident(renamed)),
+                            })
+                        }
+                    }
+                }
+            }
+            _ => {}
         }
-        n.value.visit_mut_with(self);
     }
 
     fn visit_mut_pat(&mut self, n: &mut Pat) {

bundler/tests/deno-exec/.deno-9200/case1/entry.ts

@@ -0,0 +1,3 @@
+import { isEmail } from "https://deno.land/x/segno@v1.1.0/mod.ts";
+
+isEmail("test@test.com");

bundler/tests/fixture/circular-imports/complex-export/output/entry.inlined.js

@@ -1,4 +1,5 @@
-const a1 = 'a';
+const a2 = 'a';
 const c1 = 'c';
+const a1 = a2;
 export { a1 as a };
 export { c1 as c };

bundler/tests/fixture/deno-8978/output/entry.inlined.ts

@@ -1,3 +1,4 @@
 const f = ()=>"hello world"
 ;
-export { f as any };
+const any1 = f;
+export { any1 as any };

bundler/tests/fixture/deno-9055/keywords-1/input/entry.ts

@@ -0,0 +1,9 @@
+const x = {
+    n: 123,
+    t: 'text',
+    int: '==INT=='
+}
+
+const { n, t, int } = x
+
+console.log(n, t, int)

bundler/tests/fixture/deno-9055/keywords-1/output/entry.inlined.ts

@@ -0,0 +1,7 @@
+const x = {
+    n: 123,
+    t: 'text',
+    int: '==INT=='
+};
+const { n , t , int: __int  } = x;
+console.log(n, t, __int);

bundler/tests/fixture/deno-9055/keywords-1/output/entry.ts

@@ -0,0 +1,7 @@
+const x = {
+    n: 123,
+    t: 'text',
+    int: '==INT=='
+};
+const { n , t , int: __int  } = x;
+console.log(n, t, __int);

bundler/tests/fixture/deno-9055/keywords-2/input/entry.ts

@@ -0,0 +1,9 @@
+const x = {
+    n: 123,
+    t: 'text',
+    int: '==INT=='
+}
+
+const { n, t, int = 5 } = x
+
+console.log(n, t, int)

bundler/tests/fixture/deno-9055/keywords-2/output/entry.inlined.ts

@@ -0,0 +1,7 @@
+const x = {
+    n: 123,
+    t: 'text',
+    int: '==INT=='
+};
+const { n , t , int: __int = 5  } = x;
+console.log(n, t, __int);

bundler/tests/fixture/deno-9055/keywords-2/output/entry.ts

@@ -0,0 +1,7 @@
+const x = {
+    n: 123,
+    t: 'text',
+    int: '==INT=='
+};
+const { n , t , int: __int = 5  } = x;
+console.log(n, t, __int);

bundler/tests/fixture/deno-9176/test-2/output/entry.inlined.ts

@@ -3,7 +3,8 @@ class MyError extends Error {
         super("I'm in?");
     }
 }
-function example1() {
+function example2() {
     throw new MyError();
 }
+const example1 = example2;
 export { example1 as example };

bundler/tests/fixture/deno-9200/.case1/input/deps.ts

@@ -0,0 +1,7 @@
+import * as lib from './lib';
+
+// exporting all functions
+export * from './lib';
+
+// exporting functions namespaced to segno
+export { lib };

bundler/tests/fixture/deno-9200/.case1/input/entry.ts

@@ -0,0 +1,2 @@
+import { foo } from './deps'
+foo()

bundler/tests/fixture/deno-9200/.case1/input/lib-impl1.ts

@@ -0,0 +1 @@
+export function foo() { }

bundler/tests/fixture/deno-9200/.case1/input/lib.ts

@@ -0,0 +1 @@
+export * from './lib-impl1'

bundler/tests/fixture/deno-9200/.case2/input/entry.ts

@@ -0,0 +1,7 @@
+import * as lib from './lib';
+
+// exporting all functions
+export * from './lib';
+
+// exporting functions namespaced to segno
+export { lib };

bundler/tests/fixture/deno-9200/.case2/input/lib-impl1.ts

@@ -0,0 +1 @@
+export function foo() { }

bundler/tests/fixture/deno-9200/.case2/input/lib.ts

@@ -0,0 +1 @@
+export * from './lib-impl1'

bundler/tests/fixture/deno-9212/.case1/input/entry.ts

@@ -0,0 +1,6 @@
+import * as ReactDom from "https://esm.sh/react-dom@17.0.1"
+import * as React from "https://esm.sh/react@17.0.1"
+
+const { document } = window as any
+
+ReactDom.render(React.createElement('p', null, 'hello world!'), document.body)

bundler/tests/fixture/deno-9219/case1/input/entry.ts

@@ -0,0 +1,21 @@
+import { parse } from "https://deno.land/std@0.84.0/flags/mod.ts";
+
+const args = parse(Deno.args, {
+    boolean: [
+        "help",
+        "verbose",
+    ],
+    alias: {
+        help: "h",
+        verbose: "v",
+    },
+    default: {
+        verbose: false,
+    },
+}) as {
+    _: string[];
+    help: boolean;
+    verbose: boolean;
+};
+
+console.dir(args);