fix(es/transforms/cjs): Allow mixing named exports and export stars. #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…th, according to babel output for the same code.
kdy1
requested changes
Oct 30, 2021
| @@ -155,6 +155,19 @@ where | |||
| ref specifiers, | |||
| .. | |||
| })) => { | |||
| // handle: export {sym as alias1, alias2, ...} | |||
| for ExportNamedSpecifier { orig, exported, .. } in | |||
| specifiers.into_iter().map(|e| match e { | |||
There was a problem hiding this comment.
I think filter_map with None for other cases is better.
(Although I don't have concrete input which breaks this)
There was a problem hiding this comment.
I've pushed a change to try to address this. I hope it's in line with what you were thinking - I had previously used a pattern that I saw was elsewhere in the code.
| _ => unreachable!(), | ||
| }) | ||
| { | ||
| if !exported.is_none() { |
There was a problem hiding this comment.
You can use
if let Some(exported). = &exported {
exports.push(exported.sym.clone());
}
kdy1
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at fixing #2548.
swc_ecma_transforms_module:
common_js: Fix _exportNames when exporting aliases and usingexport *s . (export {default as name} can create duplicate symbols #2548)