fix(es/transforms/module/commonjs): fix named exports overrides #2883
+105
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
reviewed
Nov 27, 2021
| @@ -89,6 +89,31 @@ where | |||
| // Used only if export * exists | |||
| let mut exported_names: Option<Ident> = None; | |||
|
|
|||
| // make a preliminary pass through to collect exported names ahead of time | |||
| for item in items.clone() { | |||
There was a problem hiding this comment.
I'm fairly new to Rust. Is there a better way to iterate a vector twice? Removing clone would cause the second iteration to fail.
There was a problem hiding this comment.
You can use for item in &items instead, as &Vec<T> implements IntoIterator<Item = &T>.
There was a problem hiding this comment.
Ah, thank you! One of these days, I will learn Rust properly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2101 and the details can be found in the issue description.
This is somewhat of a followup to PR #2583, as the PR was a incomplete solution. It only fixed named exports declared as import/export statements. Furthermore, the order of the named exports could appear before or after the wildcard exports, causing cases to be missed.
This fix requires a preliminary pass through the items to find all named exports first in order to address the ordering. Furthermore, I've moved the logic from PR #2583 into this preliminary loop instead to catch both cases where export/imports are declared as well as simple named exports.
I've used Babel REPL to compare my output to multiple use cases, which also required changing a couple of internal test outputs.
This re-ordering can cause the
_exportNamesarray to be declared sooner than previously found. I've found that Babel seems to always declare it right away.It should also be noted that the testing has changed much since my first PR, and I've tried to follow the same patterns and locations to place and run tests.