fix(es/transforms/module/commonjs): fix named exports overrides

crates/swc/tests/fixture/issue-1714/case1/output/index.js

@@ -2,6 +2,9 @@
 Object.defineProperty(exports, "__esModule", {
     value: true
 });
+var _exportNames = {
+    render: true
+};
 Object.defineProperty(exports, "render", {
     enumerable: true,
     get: function() {
@@ -12,6 +15,7 @@ var _customRender = require("./customRender");
 var _react = _interopRequireWildcard(require("@testing-library/react"));
 Object.keys(_react).forEach(function(key) {
     if (key === "default" || key === "__esModule") return;
+    if (Object.prototype.hasOwnProperty.call(_exportNames, key)) return;
     if (key in exports && exports[key] === _react[key]) return;
     Object.defineProperty(exports, key, {
         enumerable: true,

crates/swc_ecma_transforms_module/src/common_js.rs

@@ -89,6 +89,31 @@ where
         // Used only if export * exists
         let mut exported_names: Option<Ident> = None;
 
+        // make a preliminary pass through to collect exported names ahead of time
+        for item in &items {
+            match item {
+                ModuleItem::ModuleDecl(ModuleDecl::ExportNamed(NamedExport {
+                    ref specifiers,
+                    ..
+                })) => {
+                    for ExportNamedSpecifier { orig, exported, .. } in
+                        specifiers.into_iter().filter_map(|e| match e {
+                            ExportSpecifier::Named(e) => Some(e),
+                            _ => None,
+                        })
+                    {
+                        if let Some(exported) = &exported {
+                            exports.push(exported.sym.clone());
+                        } else {
+                            exports.push(orig.sym.clone());
+                        }
+                    }
+                }
+
+                _ => {}
+            }
+        }
+
         for item in items {
             self.in_top_level = true;
 
@@ -158,21 +183,9 @@ where
                             ref specifiers,
                             ..
                         })) => {
-                            // handle: export {sym as alias1, alias2, ...} from "x"
-                            for ExportNamedSpecifier { orig, exported, .. } in
-                                specifiers.into_iter().filter_map(|e| match e {
-                                    ExportSpecifier::Named(e) => Some(e),
-                                    _ => None,
-                                })
-                            {
-                                if let Some(exported) = &exported {
-                                    exports.push(exported.sym.clone());
-                                } else {
-                                    exports.push(orig.sym.clone());
-                                }
-                            }
                             scope.import_to_export(&src, !specifiers.is_empty());
                         }
+
                         _ => {}
                     }
                     drop(scope);

crates/swc_ecma_transforms_module/tests/common_js.rs

@@ -4161,6 +4161,9 @@ test!(
 Object.defineProperty(exports, "__esModule", {
     value: true
 });
+var _exportNames = {
+    Scope: true
+};
 Object.defineProperty(exports, "Scope", {
   enumerable: true,
   get: function() {
@@ -4170,6 +4173,7 @@ Object.defineProperty(exports, "Scope", {
 var _http = require("./http");
 Object.keys(_http).forEach(function(key) {
     if (key === "default" || key === "__esModule") return;
+    if (Object.prototype.hasOwnProperty.call(_exportNames, key)) return;
     if (key in exports && exports[key] === _http[key]) return;
     Object.defineProperty(exports, key, {
         enumerable: true,
@@ -4200,15 +4204,15 @@ export * from './pipes';
     Object.defineProperty(exports, "__esModule", {
         value: true
     });
+    var _exportNames = {
+      id: true
+    };
     Object.defineProperty(exports, "id", {
         enumerable: true,
         get: function() {
             return _interfaces.id;
         }
     });
-    var _exportNames = {
-        id: true
-    };
     require("reflect-metadata");
     var _http = require("./http");
     Object.keys(_http).forEach(function(key) {

crates/swc_ecma_transforms_module/tests/fixture/commonjs/issue-2101/1/input.js

@@ -0,0 +1,7 @@
+import { customRender } from './customRender';
+
+// re-export everything
+export * from '@testing-library/react';
+
+// override render method
+export { customRender as render };

crates/swc_ecma_transforms_module/tests/fixture/commonjs/issue-2101/1/output.js

@@ -0,0 +1,26 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", {
+    value: true
+});
+var _exportNames = {
+  render: true
+};
+Object.defineProperty(exports, "render", {
+    enumerable: true,
+    get: function() {
+        return _customRender.customRender;
+    }
+});
+var _customRender = require("./customRender");
+var _react = require("@testing-library/react");
+Object.keys(_react).forEach(function(key) {
+    if (key === "default" || key === "__esModule") return;
+    if (Object.prototype.hasOwnProperty.call(_exportNames, key)) return;
+    if (key in exports && exports[key] === _react[key]) return;
+    Object.defineProperty(exports, key, {
+        enumerable: true,
+        get: function() {
+            return _react[key];
+        }
+    });
+});

crates/swc_ecma_transforms_module/tests/fixture/commonjs/issue-2101/2/input.js

@@ -0,0 +1,9 @@
+import { customRender } from './customRender';
+
+// override render method
+export { customRender as render };
+
+// re-ordering the export wildcard from case 1 should make no difference to output
+
+// re-export everything
+export * from '@testing-library/react';

crates/swc_ecma_transforms_module/tests/fixture/commonjs/issue-2101/2/output.js

@@ -0,0 +1,26 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", {
+    value: true
+});
+Object.defineProperty(exports, "render", {
+    enumerable: true,
+    get: function() {
+        return _customRender.customRender;
+    }
+});
+var _exportNames = {
+    render: true
+  };
+var _customRender = require("./customRender");
+var _react = require("@testing-library/react");
+Object.keys(_react).forEach(function(key) {
+    if (key === "default" || key === "__esModule") return;
+    if (Object.prototype.hasOwnProperty.call(_exportNames, key)) return;
+    if (key in exports && exports[key] === _react[key]) return;
+    Object.defineProperty(exports, key, {
+        enumerable: true,
+        get: function() {
+            return _react[key];
+        }
+    });
+});