Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urgent: fix workflows #899

Merged
merged 2 commits into from
Nov 29, 2022
Merged

urgent: fix workflows #899

merged 2 commits into from
Nov 29, 2022

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Oct 20, 2022

This pull request updates the workflows for this lesson.

There are two items that are changed:

  1. r-lib/actions/setup-r now uses @v2 instead of @master as the default tag
  2. the set-output GHA workflow command has been updated as it was deprecated.

see carpentries/styles#641 for details

If you have any questions, contact @zkamvar

@zkamvar zkamvar mentioned this pull request Oct 20, 2022
Closed
@zkamvar zkamvar requested a review from a team November 29, 2022 16:54
kekoziar
kekoziar approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@kekoziar kekoziar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git-novice is a non-R lesson, so this doesn't impact the lesson build. I checked the PR locally, and everything renders as normal. Approved.

@kekoziar kekoziar merged commit a60bafa into gh-pages Nov 29, 2022
@kekoziar kekoziar deleted the znk-fix-workflows-2022-10-20 branch November 29, 2022 17:27
@zkamvar
Copy link
Contributor Author

zkamvar commented Nov 29, 2022

git-novice is a non-R lesson, so this doesn't impact the lesson build.

True, but the bug does affect PR statuses (e.g. #904) as detailed in the Impacts section of carpentries/styles#641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kekoziar kekoziar kekoziar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkamvar @kekoziar