-
-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify to not commit proposed change #904
Conversation
A learner missed this and had already committed the change before testing `git checkout`. This change intends to help avoid this mistake.
@lexnederbragt Having the challenge written in such a way that a learner never misses it, defeats the purpose of the challenge. Did they miss it because it's unclear, or because the learner didn't quite grasp the difference between a change being staged and committed? I'd rather not write in such a way that it takes into account each mistake a learner might make. That said, this would probably be best clarified with a solution to the challenge. Are you willing to write up a good solution instead, taking into consideration the common mistakes learners might make with this? |
I see your point and agree that my change would be making the challenge less, well, challenging. |
PR updated with a proposed solution. Please review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version git are you running? My version is prompting with git restore
not git checkout
I agree that recent versions of git use See also discussion in #691 on updating the git lesson to version of git that uses |
… add` in challenge prompt. Update 05-history.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I made some minor changes to make the input/output in the solution standardized with the rest of the lesson, and added clarification in the challenge prompt.
Thank you for submitting this solution!
A learner missed this and had already committed the change before testing
git checkout
. This change intends to help avoid this mistake.