Update to es2017 sweet-spec #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabejohnson
requested changes
Aug 16, 2017
src/enforester.js
Outdated
| @@ -183,8 +183,22 @@ export class Enforester { | |||
| let moduleSpecifier = null; | |||
There was a problem hiding this comment.
It'd probably be good to get rid of these let moduleSpecifier bindings . They're just noise at this point.
src/enforester.js
Outdated
| @@ -243,12 +257,12 @@ export class Enforester { | |||
| if (this.isIdentifier(this.peek(), 'as')) { | |||
| this.advance(); | |||
| let exportedName = this.enforestIdentifier(); | |||
| return new T.ExportSpecifier({ name, exportedName }); | |||
| return { name, exportedName }; | |||
There was a problem hiding this comment.
This could probably be consolidated to
enforestExportSpecifier() {
const name = this.enforestIdentifier();
let exportedName = null;
if (this.isIdentifier(this.peek(), 'as')) {
this.advance();
exportedName = this.enforestIdentifier();
}
return { name, exportedName };
}
src/enforester.js
Outdated
| return new T.BindingIdentifier({ name: term.inner.get(0).value }); | ||
| } | ||
| return term; | ||
| // if (term.inner.size === 1 && this.isIdentifier(term.inner.get(0))) { |
src/sweet-module.js
Outdated
| @@ -54,6 +54,11 @@ function extractSpecifiers(term: any): List<ExportSpecifier> { | |||
| return List(); | |||
| } else if (S.isExportFrom(term)) { | |||
| return term.namedExports; | |||
| } else if (S.isExportLocals(term)) { | |||
| return term.namedExports.map(s => ({ | |||
There was a problem hiding this comment.
Destructure s to make it consistent w/ line 151
disnet
force-pushed
the
refactor/update-spec-es2017
branch
from
8b8279b to
60ffc8f
Compare
|
Addressed comments. Thanks! |
disnet
force-pushed
the
refactor/update-spec-es2017
branch
from
60ffc8f to
78a8eaf
Compare
gabejohnson
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with sweet-js/sweet-spec#3