Update spec to shift ES2017 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disnet
force-pushed
the
refactor/update-spec-es2017
branch
from
119c868 to
f9ef67e
Compare
gabejohnson
reviewed
Aug 13, 2017
| @@ -35,6 +35,10 @@ declare export class MethodDefinition extends NamedObjectProperty { | |||
| body: FunctionBody; | |||
| } | |||
|
|
|||
| declare export class VariableReference extends Term { | |||
| name: any; // Identifier (string) | |||
There was a problem hiding this comment.
What's with all of these any types declarations?
There was a problem hiding this comment.
The current spec macro uses any for anything that is not a Term (anything the reducer doesn't recurse into). Not ideal so I'm also working on rewriting the spec macro (with parser combinators!) but that's taking a while.
gabejohnson
approved these changes
Aug 14, 2017
This was referenced Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sweet-spec was originally based of the ES6 version of shift spec so this updates includes all the changes from shapesecurity/shift-spec@es6...es2017#diff-448c96409569a059a7e07cf28935a2c4